Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve validate output #588

Merged
merged 1 commit into from
Feb 17, 2022
Merged

feat: improve validate output #588

merged 1 commit into from
Feb 17, 2022

Conversation

GGabriele
Copy link
Collaborator

$ deck validate --online
Error: validate entity 'services (svc1)': HTTP status 400 (message: "schema violation (host: must not have a port)")
validate entity 'certificates (13c562a1-191c-4464-9b18-e5222b46035b)': HTTP status 400 (message: "2 schema violations (cert: invalid certificate: x509.new: asn1/tasn_dec.c:309:error:0D07803A:asn1 encoding routines:asn1_item_embed_d2i:nested asn1 error; key: invalid key: pkey.new:load_key: nil failed)")
validate entity 'plugins (prometheus)': HTTP status 400 (message: "schema violation (protocols.1: expected one of: grpc, grpcs, http, https, tcp, tls, tls_passthrough, udp)")
validate entity 'snis (demo1.example.com:123)': HTTP status 400 (message: "schema violation (name: must not have a port)")

@GGabriele GGabriele requested a review from a team as a code owner February 11, 2022 07:42
@codecov-commenter
Copy link

Codecov Report

Merging #588 (3de604b) into main (299542a) will decrease coverage by 0.73%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   51.15%   50.42%   -0.74%     
==========================================
  Files          73       74       +1     
  Lines        8009     8139     +130     
==========================================
+ Hits         4097     4104       +7     
- Misses       3542     3665     +123     
  Partials      370      370              
Impacted Files Coverage Δ
validate/validate.go 5.38% <63.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299542a...3de604b. Read the comment docs.

Copy link
Member

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An E2E integration test would help here. Please add an issue for it.

@hbagdi hbagdi merged commit 8c38da4 into main Feb 17, 2022
@hbagdi hbagdi deleted the improve_validate_log branch February 17, 2022 08:42
AntoineJac pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants