fix:deck konnect commands do not honor --headers flag #468 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 51.96% 51.88% -0.09%
==========================================
Files 73 73
Lines 7730 7742 +12
==========================================
Hits 4017 4017
- Misses 3363 3375 +12
Partials 350 350
Continue to review full report at Codecov.
|
hbagdi
reviewed
Jan 3, 2022
utils/types.go
Outdated
| client, err := konnect.NewClient(httpClient, konnect.ClientOpts{ | ||
| BaseURL: address, | ||
| }) | ||
| }, headers) |
There was a problem hiding this comment.
Let's make changes only in this file and bring changes that are in konnect/client.go into this file.
This way we can keep the "client with header" logic within this file and re-use it across the Kong and Konnect clients.
hbagdi
reviewed
Jan 4, 2022
konnect/client.go
Outdated
| @@ -41,7 +41,7 @@ type ClientOpts struct { | |||
| // NewClient returns a Client which talks to Konnect's API. | |||
| func NewClient(httpClient *http.Client, opts ClientOpts) (*Client, error) { | |||
| if httpClient == nil { | |||
| httpClient = http.DefaultClient | |||
| return nil, fmt.Errorf("nil httpClient passed") | |||
There was a problem hiding this comment.
Please revert this since this change is unrelated.
hbagdi
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling header flags for konnect commands