fix: update target in-place #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targets in Kong were immutable. They were changed to be mutable a few months ago but we can't break compatibility. If target's weight was changed, it resulted in the following: - diff is detected, an update is issued - update operations are translated into delete then create, the ID changes - the update is then reflected into go-memdb, because the ID is new, state package emits an error that it can't update an entity that it didn't previously have This patch ensures that ID across update remains the same. The tests for this is here: Kong/go-kong#85
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 50.44% 50.44%
=======================================
Files 72 72
Lines 7835 7835
=======================================
Hits 3952 3952
Misses 3534 3534
Partials 349 349 Continue to review full report at Codecov.
|
rainest
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets in Kong were immutable. They were changed to be mutable a few
months ago but we can't break compatibility.
If target's weight was changed, it resulted in the following:
changes
state package emits an error that it can't update an entity that it
didn't previously have
This patch ensures that ID across update remains the same.
The tests for this is here: Kong/go-kong#85