hotfix: fix double error message prints #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incorrect change was introduced in 4717d53.
mflendrich
reviewed
Apr 8, 2021
| @@ -41,8 +41,12 @@ It can be used to export, import or sync entities to Kong.`, | |||
| // Execute adds all child commands to the root command and sets | |||
| // sflags appropriately. | |||
| // This is called by main.main(). It only needs to happen once to the rootCmd. | |||
| func Execute() error { | |||
| return rootCmd.Execute() | |||
| func Execute() { | |||
There was a problem hiding this comment.
Did you consider setting cobra.Command's SilenceErrors to true instead?
There was a problem hiding this comment.
I did. I reverted to match the past to avoid further new surprises.
mflendrich
approved these changes
Apr 8, 2021
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
This incorrect change was introduced in 4717d53.
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
This incorrect change was introduced in 598f214.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorrect change was introduced in 4717d53.