Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not print timestamps in diff output #283

Merged
merged 2 commits into from
Mar 16, 2021
Merged

fix: do not print timestamps in diff output #283

merged 2 commits into from
Mar 16, 2021

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Mar 7, 2021

Fix #142

@hbagdi hbagdi requested a review from a team as a code owner March 7, 2021 17:05
@hbagdi hbagdi merged commit 8bc5edb into main Mar 16, 2021
@hbagdi hbagdi deleted the fix/timestamp-in-diff branch March 16, 2021 19:52
@Tieske
Copy link
Member

Tieske commented Apr 16, 2021

he guys, the title is "do not print timestamp", does that mean it will still sync them, but just not showing them?

@hbagdi
Copy link
Member Author

hbagdi commented Apr 16, 2021

The bug that was reported: decK detects a diff in any property other than timestamps, then timestamps also show up in the diff.

To my knowledge, decK never synced or detected diff in the resources when only timestamp was different. If that is happening, it is a new bug.

@Tieske
Copy link
Member

Tieske commented Apr 16, 2021

thx for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doing a "deck diff" on some statefiles brings a change to the "created_at" attribute
3 participants
@hbagdi @Tieske @rainest