fix: update go-database-reconciler for fixing expression route handling #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Till now, expression routes were getting incorrectly rendered. Added changes in go-database-reconciler to allow proper rendering for both kinds of routes. Added tests here to ensure the functionality stays intact for future updates. Fix #1250.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
+ Coverage 22.36% 22.43% +0.06%
==========================================
Files 54 54
Lines 4520 4520
==========================================
+ Hits 1011 1014 +3
+ Misses 3409 3407 -2
+ Partials 100 99 -1 ☔ View full report in Codecov by Sentry. |
GGabriele
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Till now, expression routes were getting incorrectly rendered. Added changes in go-database-reconciler to allow proper rendering for both kinds of routes. Kong/go-database-reconciler#116
Added tests here to ensure the functionality stays intact for future updates.
Fix #1250.