-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(apiops): bump to v0.1.28 adds 'namespace' command #1179
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
========================================
- Coverage 5.76% 5.57% -0.19%
========================================
Files 31 32 +1
Lines 3229 3338 +109
========================================
Hits 186 186
- Misses 3033 3142 +109
Partials 10 10 ☔ View full report in Codecov by Sentry. |
cmd/file_namespace.go
Outdated
`, | ||
RunE: executeNamespace, | ||
Example: `# Apply namespace to a deckfile | ||
deck file namespace --namespace=/my-namespace --state=deckfile.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example does not contain a selector, but is required (IIUC).
The error text here may be confusing:
The error should indicate that the path-prefix value must start with '/' and not be empty. |
- fixed example in cli - updated error message on invalid path-prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.