Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error to update service with retries: 0 #134

Closed
DiegoTondim opened this issue Mar 26, 2020 · 1 comment
Closed

Error to update service with retries: 0 #134

DiegoTondim opened this issue Mar 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@DiegoTondim
Copy link

DiegoTondim commented Mar 26, 2020 •
edited
Loading

Hi,

I'm trying to get the diff of a service where the retries = 0 and decK is updating the value to 5.

Steps do reproduce:

  1. service in kong with retries: 0
  2. deck dump
  3. deck diff

You will see the service to be updated with retries = 5.

Is there any kind of default values in some place that I could change to fix that?

UPDATE

I saw the same behavior in the upstream with the property https_verify_certificate, in kong it is "false" and after diff it is changed to "true".
@hbagdi hbagdi added the bug Something isn't working label Apr 1, 2020
@hbagdi
Copy link
Member

hbagdi commented Apr 1, 2020

It seems you are running into an issue with the default injection logic.
The constants are defined here: https://github.com/hbagdi/deck/blob/master/utils/constants.go

@hbagdi hbagdi closed this as completed in 208ee33 Apr 5, 2020
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix: remove defaults for values which can be set to 0 or false
01a66ee 
This is an issue due to the underlying library (mergo).

For existing installations which are relying on defaulting behavior of
decK, this will cause false positives in diffs. This is not considered a
breaking change and hopefully will be only a small inconvenience to
users.

Fix #134
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
fix: remove defaults for values which can be set to 0 or false
4c83fa1 
This is an issue due to the underlying library (mergo).

For existing installations which are relying on defaulting behavior of
decK, this will cause false positives in diffs. This is not considered a
breaking change and hopefully will be only a small inconvenience to
users.

Fix #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hbagdi @DiegoTondim