Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument "--version" to docklet run #3870

Closed
wants to merge 1 commit into from
Closed

Add argument "--version" to docklet run #3870

wants to merge 1 commit into from

Conversation

51CGO
Copy link
Contributor

@51CGO 51CGO commented May 5, 2020

Hi,

When building Komodo, users have to specify version for mozilla build and komodo build.
But when using Docker, there was no option to docklet run to specify the version to run.

@th3coop th3coop requested a review from Naatan May 20, 2020 00:06
@th3coop
Copy link
Member

th3coop commented May 20, 2020

This doesn't look right to me but I also haven't used or looked at the docker build process. @Naatan maybe you could weigh in.

@Naatan
Copy link
Member

Naatan commented May 20, 2020

The diff look sane but frankly there's really no reason to be building with any other version at this stage, least that I can think of? What's your use-case @crigoda ?

@51CGO
Copy link
Contributor Author

51CGO commented May 22, 2020

Well, here's what happened to me:
Working on #3872, I followed the old readme to build Komodo so I build Mozilla and Komodo with version 10.10 as written in the readme...
When I tried to run it, the docklet did not find the directories because the version is hard-coded in the docklet script.
As it's possible to specify the version at build time, this should be possible to specify it at run time :)

@Naatan
Copy link
Member

Naatan commented May 25, 2020

I'm afraid the solution there is to rebuild with 12.10. Building a 12.10 build with a 10.10 version specifier can lead to unexpected results (eg. pref updater not updating certain prefs that need to be updated for v12 to operate).

I'm sorry, you'll have to rebuild :\ I'll reject this PR since the use-case is not valid, but I appreciate your contribution!

@Naatan Naatan closed this May 25, 2020
@51CGO
Copy link
Contributor Author

51CGO commented May 26, 2020

OK. This is not a big thing.
But maybe something has to be done to build automatically the good version of Mozilla and Komodo according to the version specified in the docklet...

Now I know that I must check the docklet before building. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants