[RFR] Feat/compare tags #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only adds a new CLI arg and configures the CLI. The arg will be used in the next commits.
When the --base-ref CLI arg is provided, we use it to determine the commits range start. Otherwise, we're using the `base-branch` arg to resolve the commits range start.
alexpozzi
approved these changes
Aug 26, 2024
nm2107
added a commit
that referenced
this pull request
Aug 30, 2024
optional args are provided PR [40](#40) has introduced a change in the default behavior of ssc. When running the tool as usual, there was an error raised : ``` $ ssc --path <path> --cmd <stop_command> error: a value is required for '--base-ref <BASE_REF>' but none was supplied ``` whereas it should use the base branch comparison by default (as we don't want people who are upgrading ssc to change their CI scripts). This commit fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be able to compare with tags.
Adds a new CLI arg to specify the tag to compare to.
Why ?
As the branch comparison behavior of ssc is using
git merge-basecommand, it is not working when using a tag name instead of a branch name. So in order to keep this behavior and to also be able to compare tags, a new CLI arg has been introduced.This was discussed some months ago on slack with a Knpeer which has noticed that this feature wasn't possible yet, and it is now implemented.
Usage exemple :