Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case protection for postgreSQL #130

Merged
merged 1 commit into from
May 31, 2018
Merged

Add case protection for postgreSQL #130

merged 1 commit into from
May 31, 2018

Conversation

kilnerm
Copy link
Contributor

@kilnerm kilnerm commented Apr 24, 2018

Add case protection for names.

  • Updated SwiftKuery tests to check all identifiers are wrapped in "'s. (apart from raw strings)
  • Updated build functions to wrap identifiers when building SQL statements.

Mixed case column names now work consistently across postgreSQL, mySQL and SQLite.

@kilnerm kilnerm self-assigned this Apr 24, 2018
@kilnerm kilnerm requested a review from EnriqueL8 April 24, 2018 07:17
@codecov-io
Copy link

Codecov Report

Merging #130 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   84.55%   84.58%   +0.02%     
==========================================
  Files          43       43              
  Lines        3606     3606              
==========================================
+ Hits         3049     3050       +1     
+ Misses        557      556       -1
Flag Coverage Δ
#SwiftKuery 84.58% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
Sources/SwiftKuery/Utils.swift 56% <100%> (+1.33%) ⬆️
Sources/SwiftKuery/RawField.swift 100% <100%> (ø) ⬆️
Sources/SwiftKuery/Insert.swift 97.53% <100%> (ø) ⬆️
Sources/SwiftKuery/Select.swift 86.53% <100%> (ø) ⬆️
Sources/SwiftKuery/Column.swift 90.16% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95ae01...7d0b900. Read the comment docs.

@EnriqueL8
Copy link
Contributor

This would be a BREAKING CHANGE.

@EnriqueL8 EnriqueL8 merged commit 20e4a41 into master May 31, 2018
@EnriqueL8 EnriqueL8 deleted the issue_784 branch May 31, 2018 14:40
EnriqueL8 added a commit that referenced this pull request May 31, 2018
djones6 pushed a commit that referenced this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants