Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tauri v2 #1400

Merged
merged 117 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from 109 commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
6b835d5
Fix vite build (tauri build still broken)
pierremtb Feb 6, 2024
6deac3f
Fix yarn builds with a couple of shortcuts
pierremtb Feb 7, 2024
96f8b67
Fix file creation
pierremtb Feb 7, 2024
a769812
Fix documentDir behavior
pierremtb Feb 8, 2024
7293e85
Got stream with default file
pierremtb Feb 12, 2024
a91a4fc
Clean up
pierremtb Feb 13, 2024
f8224d6
@pierremtb
pierremtb Feb 13, 2024
53327c4
Clean up
pierremtb Feb 13, 2024
7f746aa
Use 'unstable'; fix devtools callsite
paultag Feb 13, 2024
dd5c058
Bring back read_dir_recursive from v1
pierremtb Feb 14, 2024
9db101d
Fix dates
pierremtb Feb 14, 2024
05493cb
Merge branch 'main' into pierremtb/issue1349
pierremtb Feb 14, 2024
e226e4c
More fixes, incl. conf files
pierremtb Feb 15, 2024
f99b55e
cargo fmt
pierremtb Feb 15, 2024
4f2cf29
Add Updater plugin
pierremtb Feb 15, 2024
1ffb6b0
Fix types
pierremtb Feb 15, 2024
3a28d09
Fix isTauri detection and updater bootup
pierremtb Feb 15, 2024
1821f66
Merge branch 'main' into pierremtb/issue1349
pierremtb Feb 22, 2024
0772f98
Schemas
pierremtb Feb 22, 2024
7f03c33
Clean up
pierremtb Feb 22, 2024
29ac5c6
Disable devtools
pierremtb Feb 22, 2024
c35f0e1
Attempt at fixing builds
pierremtb Feb 22, 2024
1436977
WIP Ubuntu dep
pierremtb Feb 22, 2024
37071be
WIP Ubuntu dep
pierremtb Feb 22, 2024
58e6d7c
Merge branch 'main' into pierremtb/issue1349
pierremtb Feb 23, 2024
60f4522
WIP keys in debug
pierremtb Feb 23, 2024
2f65d60
Enable updater only on release builds
pierremtb Feb 23, 2024
cd84975
Reenable webtools on debug
pierremtb Feb 23, 2024
468ea74
No linux bundles
pierremtb Feb 23, 2024
a98e89f
Typo
pierremtb Feb 23, 2024
b043758
Attemp at fixing --bundles none
pierremtb Feb 23, 2024
3ab1ad6
Manual tauri debug build
pierremtb Feb 24, 2024
b7c3d43
Empty commit to trigger the CI
pierremtb Feb 24, 2024
d5f9b32
Fix settings
pierremtb Feb 24, 2024
131608a
Empty commit to trigger the CI
pierremtb Feb 24, 2024
7ac347d
Merge branch 'main' into pierremtb/issue1349
pierremtb Feb 24, 2024
89485b9
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 2, 2024
2f1b924
Add allow-create perm
pierremtb Mar 2, 2024
7d964d9
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 2, 2024
099b009
tauri-driver no cap
pierremtb Mar 4, 2024
2108b1d
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 4, 2024
6267d47
Empty commit to trigger the CI
pierremtb Mar 6, 2024
73a9f64
Clean up
pierremtb Mar 6, 2024
f3af8ef
Migrate to tauri v2
pierremtb Mar 6, 2024
3c03641
Clean up
pierremtb Mar 7, 2024
af5917f
Migrate to tauri v2
pierremtb Mar 11, 2024
fb8f1ed
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 11, 2024
81b237a
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 21, 2024
4440f18
Fix fmt
pierremtb Mar 21, 2024
d7e2aba
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 25, 2024
d03a641
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 27, 2024
34f368e
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 27, 2024
5c19d89
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 27, 2024
ac933eb
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 28, 2024
a78874d
Force BUILD_RELEASE: true
pierremtb Mar 28, 2024
aabec68
Bump tauri to new beta
pierremtb Mar 29, 2024
b657eec
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 29, 2024
0a3c68f
Merge branch 'main' into pierremtb/issue1349
pierremtb Mar 29, 2024
5884915
Fix linux tests
pierremtb Mar 29, 2024
f4e8ebc
Fix types
pierremtb Mar 29, 2024
bf4a4d6
Add --verbose to tauri-action
pierremtb Mar 29, 2024
75ef59f
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 1, 2024
055123d
Move --verbose to front
pierremtb Apr 1, 2024
a82f99d
Back to tauri-driver@0.1.3 and single \ for win
pierremtb Apr 1, 2024
8ad8e9e
Back to latest driver, and windows wip
pierremtb Apr 1, 2024
d9f836f
Disable release conf temporarily
pierremtb Apr 1, 2024
21a9ba9
Rollback to 2.0.0-beta.2
pierremtb Apr 1, 2024
fb209bb
Rollback to 2.0.0-beta.1
pierremtb Apr 1, 2024
786d49a
Move bundle to root for src-tauri/tauri.release.conf.json
pierremtb Apr 1, 2024
dbba87c
All packages to latest (add http and shell to package.json)
pierremtb Apr 2, 2024
da44f27
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 2, 2024
095873a
Testing latest commit for tauri-action
pierremtb Apr 2, 2024
93af8fa
Remove tauri action
pierremtb Apr 2, 2024
1050ea0
Add cat
pierremtb Apr 2, 2024
99c8e4a
WIP
pierremtb Apr 2, 2024
43527ed
Update ci.yml
pierremtb Apr 2, 2024
bae1575
Disable release conf
pierremtb Apr 2, 2024
67dda80
Disable rust cache
pierremtb Apr 2, 2024
7ad4dd2
Add tauri-action back for release builds
pierremtb Apr 2, 2024
2320944
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 2, 2024
8ceea72
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 2, 2024
2e02d1f
Update .codespellrc
pierremtb Apr 2, 2024
1a8af17
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 2, 2024
d71cc43
Trigger CI
pierremtb Apr 2, 2024
e44dc60
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 3, 2024
d9246fc
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 3, 2024
caf8c2f
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 3, 2024
c5f43ec
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 3, 2024
229e4e5
Fix type
pierremtb Apr 3, 2024
844a218
Clean up
pierremtb Apr 3, 2024
3478b8d
More clean up
pierremtb Apr 3, 2024
9e9bbe6
Fix path concatenation with join
pierremtb Apr 3, 2024
6c2d97f
Attempt at fixing linux tests
pierremtb Apr 4, 2024
8f66d54
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 4, 2024
d596a65
Config clean up
pierremtb Apr 4, 2024
fb008dd
Downgrade to tauri-driver@0.1.3
pierremtb Apr 4, 2024
1a4fd9a
Looks like tauri v2 is actually doing better with linux package names…
pierremtb Apr 4, 2024
b02972d
Change Linux apt packages
pierremtb Apr 4, 2024
77cb7bb
Increase wdio connectionRetryTimeout
pierremtb Apr 4, 2024
1c7a853
Revert connectionRetryTimeout and bump tauri packages
pierremtb Apr 4, 2024
709b1b6
Back to latest tauri-driver
pierremtb Apr 4, 2024
522ed5a
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 5, 2024
70d29fa
Disable linux e2e tests
pierremtb Apr 5, 2024
96e8fd8
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 5, 2024
1c119f6
Trigger CI
pierremtb Apr 5, 2024
7846136
Clean up
pierremtb Apr 5, 2024
a8094ba
Update snapshots
adamchalmers Apr 5, 2024
b5801e2
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 5, 2024
85db290
Trigger CI
pierremtb Apr 5, 2024
4fbbf51
Remove @sentry/react
pierremtb Apr 5, 2024
32d0258
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 5, 2024
5fe8587
Rename migrated.json to desktop.json
pierremtb Apr 8, 2024
8fc27cb
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 8, 2024
4978d7b
Merge branch 'main' into pierremtb/issue1349
pierremtb Apr 9, 2024
bb66710
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Apr 9, 2024
f5faa8e
Trigger CI
pierremtb Apr 9, 2024
3515346
Change wasm url to http on Windows
pierremtb Apr 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codespellrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[codespell]
ignore-words-list: crate,everytime,inout,co-ordinate,ot,nwo,absolutey,atleast
skip: **/target,node_modules,build,**/Cargo.lock,./docs/kcl/*.md
skip: **/target,node_modules,build,**/Cargo.lock,./docs/kcl/*.md,./src-tauri/gen/schemas
26 changes: 17 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ jobs:
fail-fast: false
matrix:
os: [macos-14, ubuntu-latest, windows-latest]
env:
TAURI_ARGS_MACOS: ${{ matrix.os == 'macos-14' && '--target universal-apple-darwin' || '' }}
TAURI_ARGS_UBUNTU: ${{ matrix.os == 'ubuntu-latest' && '--bundles' || '' }}
steps:
- uses: actions/checkout@v4

Expand All @@ -144,10 +147,12 @@ jobs:
sudo apt-get update &&
sudo apt-get install -y
libgtk-3-dev
libgtksourceview-3.0-dev
webkit2gtk-4.0
libappindicator3-dev
libayatana-appindicator3-dev
webkit2gtk-driver
libsoup-3.0-dev
libjavascriptcoregtk-4.1-dev
libwebkit2gtk-4.1-dev
at-spi2-core
xvfb

- name: Sync node version and setup cache
Expand All @@ -161,7 +166,9 @@ jobs:
- name: Setup Rust
uses: dtolnay/rust-toolchain@stable

# TODO: re-enable for Windows builds, see https://github.com/tauri-apps/tauri/issues/9045
- name: Setup Rust cache
if: matrix.os != 'windows-latest'
uses: swatinem/rust-cache@v2
with:
workspaces: './src-tauri -> target'
Expand Down Expand Up @@ -224,14 +231,14 @@ jobs:
with:
includeRelease: false
includeDebug: true
args: ${{ matrix.os == 'macos-14' && '--target universal-apple-darwin' || '' }}
args: "${{ env.TAURI_ARGS_MACOS }} ${{ env.TAURI_ARGS_UBUNTU }}"

- name: Build the app (release) and sign
uses: tauri-apps/tauri-action@v0
if: ${{ env.BUILD_RELEASE == 'true' }}
env:
TAURI_PRIVATE_KEY: ${{ secrets.TAURI_PRIVATE_KEY }}
TAURI_KEY_PASSWORD: ${{ secrets.TAURI_KEY_PASSWORD }}
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
Expand All @@ -240,7 +247,7 @@ jobs:
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
TAURI_CONF_ARGS: "--config ${{ matrix.os == 'windows-latest' && 'src-tauri\\tauri.release.conf.json' || 'src-tauri/tauri.release.conf.json' }}"
with:
args: "${{ matrix.os == 'macos-14' && '--target universal-apple-darwin' || '' }} ${{ env.TAURI_CONF_ARGS }}"
args: "${{ env.TAURI_CONF_ARGS }} ${{ env.TAURI_ARGS_MACOS }} ${{ env.TAURI_ARGS_UBUNTU }}"

- uses: actions/upload-artifact@v3
if: matrix.os != 'ubuntu-latest'
Expand All @@ -250,10 +257,11 @@ jobs:
with:
path: "${{ env.PREFIX }}/${{ env.MODE }}/bundle/*/*"

# TODO: re-enable linux e2e tests when possible
- name: Run e2e tests (linux only)
if: matrix.os == 'ubuntu-latest'
if: false
run: |
cargo install tauri-driver@0.1.3
cargo install tauri-driver
source .env.${{ env.BUILD_RELEASE == 'true' && 'production' || 'development' }}
export VITE_KC_API_BASE_URL
xvfb-run yarn test:e2e:tauri
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,6 @@ e2e/playwright/export-snapshots/*

## generated files
src/**/*.typegen.ts
src-tauri/gen

src/wasm-lib/grackle/stdlib_cube_partial.json
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 9 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@
"@open-rpc/client-js": "^1.8.1",
"@react-hook/resize-observer": "^1.2.6",
"@replit/codemirror-interact": "^6.3.0",
"@tauri-apps/api": "^1.5.3",
"@sentry/react": "^7.77.0",
pierremtb marked this conversation as resolved.
Show resolved Hide resolved
"@tauri-apps/api": "^2.0.0-beta.7",
"@tauri-apps/plugin-dialog": "^2.0.0-beta.2",
"@tauri-apps/plugin-fs": "^2.0.0-beta.2",
"@tauri-apps/plugin-http": "^2.0.0-beta.2",
"@tauri-apps/plugin-os": "^2.0.0-beta.2",
"@tauri-apps/plugin-shell": "^2.0.0-beta.2",
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^14.0.0",
"@testing-library/user-event": "^14.5.2",
Expand Down Expand Up @@ -48,7 +54,6 @@
"react-router-dom": "^6.22.3",
"sketch-helpers": "^0.0.4",
"swr": "^2.2.2",
"tauri-plugin-fs-extra-api": "https://github.com/tauri-apps/tauri-plugin-fs-extra#v1",
"three": "^0.160.0",
"toml": "^3.0.0",
"ts-node": "^10.9.2",
Expand Down Expand Up @@ -86,7 +91,7 @@
"remove-importmeta": "sed -i 's/import.meta.url/window.location.origin/g' \"./src/wasm-lib/pkg/wasm_lib.js\"; sed -i '' 's/import.meta.url/window.location.origin/g' \"./src/wasm-lib/pkg/wasm_lib.js\" || echo \"sed for both mac and linux\"",
"wasm-prep": "rm -rf src/wasm-lib/pkg && mkdir src/wasm-lib/pkg && rm -rf src/wasm-lib/kcl/bindings",
"lint": "eslint --fix src",
"bump-jsons": "echo \"$(jq --arg v \"$VERSION\" '.version=$v' package.json --indent 2)\" > package.json && echo \"$(jq --arg v \"$VERSION\" '.package.version=$v' src-tauri/tauri.conf.json --indent 2)\" > src-tauri/tauri.conf.json",
"bump-jsons": "echo \"$(jq --arg v \"$VERSION\" '.version=$v' package.json --indent 2)\" > package.json && echo \"$(jq --arg v \"$VERSION\" '.version=$v' src-tauri/tauri.conf.json --indent 2)\" > src-tauri/tauri.conf.json",
"postinstall": "yarn xstate:typegen",
"xstate:typegen": "yarn xstate typegen \"src/**/*.ts?(x)\""
},
Expand All @@ -112,7 +117,7 @@
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/preset-env": "^7.24.3",
"@playwright/test": "^1.39.0",
"@tauri-apps/cli": "^1.5.11",
"@tauri-apps/cli": "^2.0.0-beta.12",
"@types/crypto-js": "^4.2.2",
"@types/debounce-promise": "^3.1.9",
"@types/pixelmatch": "^5.2.6",
Expand Down
Loading
Loading