Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in driver-implemented vkSetDebugUtilsObjectNameEXT for VkSemaphore's generated by the extention layer #411

Conversation

James2022-rgb
Copy link
Contributor

When the device's native driver implements the VK_EXT_debug_utils extension,
its vkSetDebugUtilsObjectNameEXT would crash for VkSemaphore's generated by the timeline semaphore extension layer.

@ci-tester-lunarg
Copy link
Collaborator

Author James2022-rgb not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 232895.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 939 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 939 failed.

@James2022-rgb
Copy link
Contributor Author

Should I do something about the code formatting for the old code (code presumably from before formatting enforcement) ?

@jeremyg-lunarg
Copy link
Collaborator

Should I do something about the code formatting for the old code (code presumably from before formatting enforcement) ?

Yes this code predates the coding standard. I think it this case it would be reasonable to fix the formatting you touched (i.e apply the output of git clang format shown here).

Also based on the output of that job, it looks like you should rebase to a more current origin/main. Probably not a big deal since this file hardly every changes but you never know...

Thanks for the fix!

@James2022-rgb James2022-rgb force-pushed the feature/fix_timsem_crash_objectname branch from e2eef25 to 4d285f7 Compare August 13, 2024 12:44
@ci-tester-lunarg
Copy link
Collaborator

Author James2022-rgb not on autobuild list. Waiting for curator authorization before starting CI build.

@James2022-rgb
Copy link
Contributor Author

Thanks, already applied thegit clang format result for my changes so just did a rebase, build/run test and a force push.

Native driver's vkSetDebugUtilsObjectNameEXT would crash for
this layer's VkSemaphore's.
@jeremyg-lunarg jeremyg-lunarg force-pushed the feature/fix_timsem_crash_objectname branch from 4d285f7 to e21971f Compare August 13, 2024 13:20
@ci-tester-lunarg
Copy link
Collaborator

Author James2022-rgb not on autobuild list. Waiting for curator authorization before starting CI build.

@jeremyg-lunarg
Copy link
Collaborator

Ok, I just did a maintainer push that should fix it.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build queued with queue ID 234879.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 941 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ExtensionLayer build # 941 passed.

@jeremyg-lunarg jeremyg-lunarg merged commit c826a1f into KhronosGroup:main Aug 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants