-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in driver-implemented vkSetDebugUtilsObjectNameEXT
for VkSemaphore
's generated by the extention layer
#411
Fix crash in driver-implemented vkSetDebugUtilsObjectNameEXT
for VkSemaphore
's generated by the extention layer
#411
Conversation
Author James2022-rgb not on autobuild list. Waiting for curator authorization before starting CI build. |
CI Vulkan-ExtensionLayer build queued with queue ID 232895. |
CI Vulkan-ExtensionLayer build # 939 running. |
CI Vulkan-ExtensionLayer build # 939 failed. |
Should I do something about the code formatting for the old code (code presumably from before formatting enforcement) ? |
Yes this code predates the coding standard. I think it this case it would be reasonable to fix the formatting you touched (i.e apply the output of Also based on the output of that job, it looks like you should rebase to a more current origin/main. Probably not a big deal since this file hardly every changes but you never know... Thanks for the fix! |
e2eef25
to
4d285f7
Compare
Author James2022-rgb not on autobuild list. Waiting for curator authorization before starting CI build. |
Thanks, already applied the |
Native driver's vkSetDebugUtilsObjectNameEXT would crash for this layer's VkSemaphore's.
4d285f7
to
e21971f
Compare
Author James2022-rgb not on autobuild list. Waiting for curator authorization before starting CI build. |
Ok, I just did a maintainer push that should fix it. |
CI Vulkan-ExtensionLayer build queued with queue ID 234879. |
CI Vulkan-ExtensionLayer build # 941 running. |
CI Vulkan-ExtensionLayer build # 941 passed. |
When the device's native driver implements the
VK_EXT_debug_utils
extension,its
vkSetDebugUtilsObjectNameEXT
would crash forVkSemaphore
's generated by the timeline semaphore extension layer.