Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c: wrap spvc_compiler_set_entry_point in error scope #2372

Merged
merged 1 commit into from
Sep 2, 2024
Merged

c: wrap spvc_compiler_set_entry_point in error scope #2372

merged 1 commit into from
Sep 2, 2024

Conversation

chyyran
Copy link
Contributor

@chyyran chyyran commented Aug 31, 2024 •
edited
Loading

spvc_compiler_set_entry_point should be wrapped in SPVC_BEGIN_SAFE_SCOPE / SPVC_END_SAFE_SCOPE to avoid unwind over FFI when the entry point is not found.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@HansKristian-Work HansKristian-Work merged commit caebe2f into KhronosGroup:main Sep 2, 2024
6 checks passed
@chyyran chyyran deleted the c_wrap_set_entry_point_in_handler branch September 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKristian-Work HansKristian-Work HansKristian-Work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chyyran @CLAassistant @HansKristian-Work