Add option to enforce fragment execution with side effects in MSL #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metal will incorrectly discard fragments with side effects under certain circumstances prematurely. The conditions are the following: - Fragment will always be discarded after side effect operation - Pre fragment depth fails - Modifies depth value for a constant value in the fragment shader. This constant value will also fail the depth test. However, Metal will also discard the fragment even if it has operations with side effects inside the fragment shader before the discard operation. Vulkan states the graphics pipeline to execute in the following order: - Pre fragment depth test (cannot discard here due to modifying depth value in fragment shader) - Fragment shader (where the depth is modified and fragment discarded) - Post fragment depth test Therefore, we need to enforce fragment shader execution and not let Metal discard the fragment before that for such cases. This change adds an option to provide such utility.
Merged
|
Merged to main. |
|
Super cursed that we have to add a million workarounds for their broken shader compiler though ._. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2322
Metal will incorrectly discard fragments with side effects under certain circumstances prematurely. The conditions are the following:
However, Metal will also discard the fragment even if it has operations with side effects inside the fragment shader before the discard operation.
Vulkan states the graphics pipeline to execute in the following order:
Therefore, we need to enforce fragment shader execution and not let Metal discard the fragment before that for such cases. This change adds an option to provide such utility.