Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.3.1: Create Helm Chart for EJBCA External Issuer for cert-manager and tidy up permissions #9

Merged
merged 14 commits into from
Dec 20, 2023
Merged

v1.3.1: Create Helm Chart for EJBCA External Issuer for cert-manager and tidy up permissions #9

merged 14 commits into from
Dec 20, 2023

Conversation

m8rmclaren
Copy link
Contributor

@m8rmclaren m8rmclaren commented Sep 22, 2023 •
edited
Loading

v1.3.1

Features

  • feat(controller): Implement Kubernetes client-go REST client for Secret/ConfigMap retrieval to bypass controller-runtime caching system. This enables the reconciler to retrieve Secret and ConfigMap resources at the namespace scope with only namespace-level permissions.
  • feat(ci): Add GitHub Actions workflows to run unit tests and release container images when appropriate
  • feat(helm): Create Helm chart to deploy the controller to a Kubernetes or OpenShift cluster

Fixes

  • fix(controller): Add logic to read secret from reconciler namespace or Issuer namespace depending on Helm configuration.

@m8rmclaren m8rmclaren added the enhancement New feature or request label Sep 22, 2023
@m8rmclaren m8rmclaren self-assigned this Sep 22, 2023
@m8rmclaren m8rmclaren mentioned this pull request Sep 22, 2023
Closed
@Syndlex
Copy link

Syndlex commented Nov 21, 2023

any reason this is not merged?

@m8rmclaren m8rmclaren changed the base branch from main to v1.3.1 November 21, 2023 21:55
@m8rmclaren m8rmclaren linked an issue Nov 21, 2023 that may be closed by this pull request
Create ejbca-cert-manager-issuer Helm chart #6
Closed
@m8rmclaren m8rmclaren linked an issue Dec 5, 2023 that may be closed by this pull request
Ensure that CertificateRequest reconciler populates CertificateRequestStatus with values to maintain feature-parity with cert-manager #3
Closed
@m8rmclaren m8rmclaren changed the title feat(helm): Create Helm Chart for EJBCA External Issuer for cert-manager v1.3.1: Create Helm Chart for EJBCA External Issuer for cert-manager and tidy up permissions Dec 7, 2023
svenska-primekey
svenska-primekey approved these changes Dec 7, 2023
View reviewed changes
Copy link

@svenska-primekey svenska-primekey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@fiddlermikey fiddlermikey merged commit 561764b into v1.3.1 Dec 20, 2023
@m8rmclaren m8rmclaren deleted the helm branch December 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenska-primekey svenska-primekey svenska-primekey approved these changes

Assignees

@m8rmclaren m8rmclaren

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@m8rmclaren @Syndlex @svenska-primekey @fiddlermikey