Login Page: New design with diaspora* login option #87
Conversation
|
THERE ARE NO LABELS! |
|
Why the SVG opti. in this PR ?! The word Login as verb doesn't exist. (Use "Log in to Kaidan" or even better "Log in to your Jabber-account") |
|
I added new images anyway, and of course optimized them, I can optimize the kaidan logo later, but that would not make so much sense. |
|
It doesn't make sense to optimize a file in a PR that improves the login page! |
src/qml/LoginPage.qml
Outdated
| GridLayout { | ||
| columns: 2 | ||
| Column { | ||
| id: mainLayout |
There was a problem hiding this comment.
Don't add an id, if you don't use it.
src/qml/LoginPage.qml
Outdated
| placeholderText: qsTr("user@example.org") | ||
| Layout.fillWidth: true | ||
| Kirigami.Heading { | ||
| text: "Login to Kaidan" |
src/qml/LoginPage.qml
Outdated
| Controls.ToolButton { | ||
| height: serviceBar.height | ||
| onClicked: { | ||
| jidField.placeholderText = qsTr("username@pod (This will be your Jabber ID)"); |
There was a problem hiding this comment.
Be uniformly: Don't call it "user@xyz" once and then "username@xzy"
Don't just call it "@pod", use a fitting form e.g. "@diaspora-pod.org".
And remove this text in the clambs. It's not necessary.
And another thing: you could also rename the button to "Jabber/Diaspora-ID" (or instead of this).
Use new diaspora logo (svg) from dandelion app Small corrections
lnjX
changed the title
There are still a few style related problems in Material style.
This also optimizes the svg graphics for size.