Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some minor fixes to code #170

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Add some minor fixes to code #170

merged 5 commits into from
Sep 2, 2024

Conversation

jorgensd
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@keiyamamo keiyamamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jorgensd

Thank you for nice suggestions. It does not pass CI right now due to some minor flake8 issues. But otherwise, it looks great.

src/vasp/automatedPreprocessing/automated_preprocessing.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (1c34f11) to head (ae04ff4).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...asp/automatedPreprocessing/generate_solid_probe.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   79.03%   78.81%   -0.22%     
==========================================
  Files          32       32              
  Lines        3777     3743      -34     
==========================================
- Hits         2985     2950      -35     
- Misses        792      793       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keiyamamo keiyamamo merged commit b56d5de into master Sep 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants