[202205] Fix issue: user must set admin down before toggling LPM #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
reviewed
Mar 16, 2023
| log_port_list = cls.get_logical_ports(sdk_handle, sdk_index, slot_id) | ||
| up_port_list, down_port_list = cls.get_logical_ports(sdk_handle, sdk_index, slot_id) | ||
| if up_port_list and lpmode: | ||
| print('Error: Please put port in admin down state before entering low power mode') |
There was a problem hiding this comment.
shall we display all the relevant ports that are still in 'admin up' status here?
There was a problem hiding this comment.
we don't have logical port name in this context
Junchao-Mellanox
changed the title
keboliu
approved these changes
Mar 21, 2023
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Dec 15, 2023
…lly (sonic-net#17436) #### Why I did it src/sonic-gnmi ``` * 88e82d4 - (HEAD -> master, origin/master, origin/HEAD) Replace PFC_WD_TABLE with PFC_WD (#173) (8 days ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Apr 15, 2024
…lly (sonic-net#18600) #### Why I did it src/sonic-gnmi ``` * cf52c74 - (HEAD -> 202311, origin/202311) Replace PFC_WD_TABLE with PFC_WD (#173) (21 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
May 10, 2024
…lly (sonic-net#18824) #### Why I did it src/sonic-gnmi ``` * 530c6bb - (HEAD -> 202311, origin/202311) Merge pull request #220 from sonic-net/revert-211-cherry/202311/173 (3 days ago) [Ying Xie] * db6f983 - (origin/revert-211-cherry/202311/173) Revert "Replace PFC_WD_TABLE with PFC_WD (#173)" (8 days ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jul 29, 2024
…lly (sonic-net#18104) #### Why I did it src/sonic-gnmi ``` * 50849ce - (HEAD -> 202305, origin/202305) Replace PFC_WD_TABLE with PFC_WD (#173) (22 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jul 29, 2024
…lly (sonic-net#18574) #### Why I did it src/sonic-gnmi ``` * 4b12af9 - (HEAD -> 202305, origin/202305) Merge pull request #209 from zbud-msft/revert_pfcwd_202305 (2 minutes ago) [StormLiangMS] * 802dbb7 - Revert "Replace PFC_WD_TABLE with PFC_WD (#173)" (28 hours ago) [Zain Budhwani] * e1397c4 - Revert "Account for GLOBAL key in PFC_WD (#178)" (28 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Aug 8, 2024
…lly (sonic-net#19731) #### Why I did it src/sonic-gnmi ``` * 4e6f5b1 - (HEAD -> 202405, origin/202405) Merge pull request sonic-net#277 from zbud-msft/revert_pfcwd_202405 (3 hours ago) [bingwang-ms] * 547241a - Rerun pipeline (25 hours ago) [Zain Budhwani] * 9785246 - Revert "Replace PFC_WD_TABLE with PFC_WD (#173)" (25 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)