Skip to content

Commit

Permalink
Add libc-bin to library aliases (#19)
Browse files Browse the repository at this point in the history
Fixes library dependency on Ubuntu 17.04.
  • Loading branch information
sambitdash authored and nalimilan committed Aug 10, 2017
1 parent 2631c9a commit f0ecb57
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,3 +149,7 @@ julia> readstring(s) # Decoding happens automatically here
Do not forget to call `close` on `StringEncoder` and `StringDecoder` objects to finish the encoding process. For `StringEncoder`, this function calls `flush`, which writes any characters still in the buffer, and possibly some control sequences (for stateful encodings). For both `StringEncoder` and `StringDecoder`, `close` checks that there are no incomplete sequences left in the input stream, and raise an `IncompleteSequenceError` if that's the case. It will also free iconv resources immediately, instead of waiting for garbage collection.

Conversion currently raises an error if an invalid byte sequence is encountered in the input, or if some characters cannot be represented in the target enconding. It is not yet possible to ignore such characters or to replace them with a placeholder.

## Notes on Installation on Linux OS

Most Linux distributions provide `iconv` functionalities as part of the base operating system library `glibc`. In normal circumstances, no additional installation of `libiconv` should be required. If you observe such a behavior on your operating system, file an issue with OS details.
2 changes: 1 addition & 1 deletion deps/build.jl
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function validate_iconv(n, h)
return ret == -1 % Csize_t && Libc.errno() == Libc.EILSEQ
end

libiconv = library_dependency("libiconv", aliases = ["libc", "iconv"],
libiconv = library_dependency("libiconv", aliases = ["libc", "libc-bin", "iconv"],
validate = validate_iconv)

if is_windows()
Expand Down

0 comments on commit f0ecb57

Please sign in to comment.