Mark the integration tests as "skipped" on PR builds #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dpa/merge-queue #479 +/- ##
================================================
Coverage 99.24% 99.24%
================================================
Files 12 12
Lines 395 395
================================================
Hits 392 392
Misses 3 3 ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
…, and add some more unit tests (#477) * Run the integration tests on the `merge_group` event * Run the unit tests on the `merge_group` event * Delete `bors.toml` (the Bors config file) * CompatHelper's own Project.toml: add compat entries for our own test deps (#478) * Update .github/workflows/ci_integration.yml Co-authored-by: mattBrzezinski <matt.brzezinski@invenia.ca> * Update ci_integration.yml * Upload code coverage from the unit tests * Integration tests: immediately error if this is a PR build * Mark the integration tests as "skipped" on PR builds (#479) * Simplify the job name of the integration tests job This is necessary because the `${{ matrix... }}` interpolations are not evaluated for skipped jobs * Do some debugging * Revert the debugging commit * Don't use a matrix for the integration test job * Do some debugging * Revert the debugging commit * Delete some commented-out lines * Fix a comment * add codecov threshold (#480) * add codecov threshold to help with #477 * Update codecov.yml * fix indentation * Update codecov.yml * Update codecov.yml * Apply suggestions from code review Co-authored-by: Dilum Aluthge <dilum@aluthge.com> * Update codecov.yml * try to make two settings exclusive * Refactor some code, and increase the unit test code coverage for `src/main.jl` (#481) * Revert the changes to `codecov.yml` (#482) * Lower Codecov threshold to 99% because of GitHub Merge Queue limitations (#484) --------- Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Co-authored-by: mattBrzezinski <matt.brzezinski@invenia.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #477