Do not use GLPK's presolve in default Polyhedra backend #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
added
discussion 🗣️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: I am not convinced about this PR aynmore. It actually does not resolve the OP in #3039 and also not #3456, which was my motivation (I should have checked before opening). Hence I close this PR again. I keep the branch in case this is interesting in the future.
Original text
This addresses the long-standing #3039 by changing the default solver to
GLPKwithout presolve.And we actually already removed it in #3333 from one method due to annoying outputs.
We added the presolve option in #2195 because sometimes the solver crashes if the presolve option is not used. I went through the tests and added the option manually in these cases.