Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend arguments in concrete minkowski sum #1495

Merged
merged 4 commits into from
Jul 4, 2019
Merged

Conversation

mforets
Copy link
Member

@mforets mforets commented Jul 3, 2019

This PR passes the backend argument to vertices_list when needed which would be otherwise ignored.

There is also a fix in the sizehint.

@mforets mforets requested a review from schillic July 3, 2019 18:26
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected that you do

function _vertices_list(P::AbstractPolytope, backend)
    return vertices_list(P)
end
function _vertices_list(P::HPolytope, backend)
    return vertices_list(P, backend=backend)
end

so it also affects the first method with AbstractPolytope (which might be an HPolytope).

@mforets mforets merged commit 7d00f3c into master Jul 4, 2019
@mforets mforets deleted the mforets/fix_msum branch July 4, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants