Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track whether or not using and import are in global scope #10

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Track whether or not using and import are in global scope #10

merged 3 commits into from
Nov 13, 2023

Conversation

Pangoraw
Copy link
Member

Will be needed in Pluto to fix:

fonsp/Pluto.jl#2678

And not run using XXX globally when it is not supposed to be. Also move from Set{Expr} to Vector{Expr}. We can still build a set for external package names and such.

Note

this is breaking

@fonsp
Copy link
Member

fonsp commented Nov 13, 2023

Nice! I renamed usings_global to usings_isglobal

@fonsp fonsp merged commit eeb876d into main Nov 13, 2023
5 checks passed
@fonsp fonsp deleted the usings_imports_global branch November 13, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pangoraw @fonsp