Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCALAPACK: Support MPItrampoline #5167

Merged
merged 8 commits into from
Jul 25, 2022
Merged

SCALAPACK: Support MPItrampoline #5167

merged 8 commits into from
Jul 25, 2022

Conversation

eschnett
Copy link
Contributor

@eschnett eschnett commented Jul 17, 2022 •
edited
Loading

This PR adds support for MPItrampoline. It also

@eschnett eschnett marked this pull request as ready for review July 17, 2022 01:10
@ViralBShah
Copy link
Member

For BLAS and LAPACK, it would be great to start linking to -lblastrampoline.

@eschnett
Copy link
Contributor Author

-lblastrampoline might actually simplify things.

@giordano
Copy link
Member

libblastrampoline doesn't solve the fact you'll need to make sure to have a backing BLAS with the right interface

@ViralBShah
Copy link
Member

Not sure I understand the comment. Isn't linking to LBT sufficient since Julia then provides the right BLAS and LAPACK?

@giordano
Copy link
Member

Not really. Julia provides an ILP64 BLAS on 64-bit, but what's the expected interface of the package here? If you remove the dance the rename all symbols here, you'll be basically expecting an LP64 BLAS, which Julia does not provide

@eschnett eschnett marked this pull request as draft July 19, 2022 21:21
@eschnett eschnett marked this pull request as ready for review July 19, 2022 21:31
benjaminfaber added a commit to benjaminfaber/VMEC_jll that referenced this pull request Jul 21, 2022
@benjaminfaber
Per JuliaPackaging#5167, scalapack can't use libblastrampoline, rever…
edd7c46 
…t back to mkl and openblas and julia1.6
@eschnett
Copy link
Contributor Author

I assume that all artefacts are rebuilt when this PR are merged. If so, this PR will automatically require MPItrampoline 5.

@eschnett
Merge branch 'master' into eschnett/SCALAPACK-mpitrampoline
02d145d 
* master: (45 commits)
  iso_codes v4.10.0 (JuliaPackaging#5226)
  PTSCOTCH: Require MPItrampoline 5, and build with OpenMPI as well (JuliaPackaging#5180)
  MAGEMin: Require MPItrampoline 5 (JuliaPackaging#5222)
  LAMMPS: Require MPItrampoline 5 (JuliaPackaging#5221)
  CrypoMiniSat: Require MPItrampoline 5 (JuliaPackaging#5219)
  PETSc: Require MPItrampoline 5 (JuliaPackaging#5223)
  [SBML] missing functions patch (JuliaPackaging#5224)
  HYPRE: Require MPItrampoline 5 (JuliaPackaging#5220)
  openPMD_api: Require MPItrampoline 5 (JuliaPackaging#5218)
  COSMA: Simplify configuring OpenMPI (JuliaPackaging#5217)
  AMReX: Require MPItrampoline 5 (JuliaPackaging#5215)
  Register Elfutils executables. (JuliaPackaging#5214)
  Wizard recipe: DDSCAT-v7.3.3 (JuliaPackaging#5210)
  ADIOS2: Require MPItrampoline 5 (JuliaPackaging#5212)
  Bump compat bounds of Python_jll dependencies. (JuliaPackaging#5211)
  mpi.jl: Require version 5 of MPItrampoline (JuliaPackaging#5209)
  [web3go] Add new package (JuliaPackaging#5195)
  add tls config patch for FLINT 2.9.0 (JuliaPackaging#5207)
  Upgrade enzyme to refs/tags/v0.0.35 (JuliaPackaging#5200)
  [PROJ] bump version to 9.0.1 (JuliaPackaging#5208)
  ...
@giordano giordano merged commit cb28ee1 into JuliaPackaging:master Jul 25, 2022
@eschnett eschnett deleted the eschnett/SCALAPACK-mpitrampoline branch July 25, 2022 22:14
giordano pushed a commit that referenced this pull request Jul 25, 2022
@benjaminfaber
[VMEC] Update dependency versions (#5184)
4cb8a36 
* No longer need to fix the versioning of dependencies

* Change dependencies to MPItrampoline and libblastrampoline

* Remove empty Windows build, builds with MPItrampoline

* Fix sha256 to v1.2.0

* Per #5167, scalapack can't use libblastrampoline, revert back to mkl and openblas and julia1.6

* Re-enable empty windows lib for dependency purposes

* Fixed issue where MPI version is not added to artifact

* Added patch to fix compilation errors with MPItrampoline

* Fix hold-over from testing

* Fixed holdover from testing preventing MKL library from building
eschnett added a commit to eschnett/Yggdrasil that referenced this pull request Jul 25, 2022
@eschnett
Merge branch 'master' into eschnett/SCALAPACK32-mpitrampoline
7359bc0 
* master: (49 commits)
  LaMEM: Support MPItrampoline (JuliaPackaging#5229)
  [VMEC] Update dependency versions (JuliaPackaging#5184)
  [xycewrapper] add julia 1.8 support (JuliaPackaging#5228)
  Elemental: Require MPItrampoline 5, enable OpenMPI (JuliaPackaging#5185)
  P4est: Support MPItrampoline (JuliaPackaging#5163)
  SCALAPACK: Support MPItrampoline (JuliaPackaging#5167)
  iso_codes v4.10.0 (JuliaPackaging#5226)
  PTSCOTCH: Require MPItrampoline 5, and build with OpenMPI as well (JuliaPackaging#5180)
  MAGEMin: Require MPItrampoline 5 (JuliaPackaging#5222)
  LAMMPS: Require MPItrampoline 5 (JuliaPackaging#5221)
  CrypoMiniSat: Require MPItrampoline 5 (JuliaPackaging#5219)
  PETSc: Require MPItrampoline 5 (JuliaPackaging#5223)
  [SBML] missing functions patch (JuliaPackaging#5224)
  HYPRE: Require MPItrampoline 5 (JuliaPackaging#5220)
  openPMD_api: Require MPItrampoline 5 (JuliaPackaging#5218)
  COSMA: Simplify configuring OpenMPI (JuliaPackaging#5217)
  AMReX: Require MPItrampoline 5 (JuliaPackaging#5215)
  Register Elfutils executables. (JuliaPackaging#5214)
  Wizard recipe: DDSCAT-v7.3.3 (JuliaPackaging#5210)
  ADIOS2: Require MPItrampoline 5 (JuliaPackaging#5212)
  ...
eschnett added a commit to eschnett/Yggdrasil that referenced this pull request Jul 25, 2022
@eschnett
Merge branch 'master' into eschnett/MSTM-mpitrampoline
2b5359c 
* master: (49 commits)
  LaMEM: Support MPItrampoline (JuliaPackaging#5229)
  [VMEC] Update dependency versions (JuliaPackaging#5184)
  [xycewrapper] add julia 1.8 support (JuliaPackaging#5228)
  Elemental: Require MPItrampoline 5, enable OpenMPI (JuliaPackaging#5185)
  P4est: Support MPItrampoline (JuliaPackaging#5163)
  SCALAPACK: Support MPItrampoline (JuliaPackaging#5167)
  iso_codes v4.10.0 (JuliaPackaging#5226)
  PTSCOTCH: Require MPItrampoline 5, and build with OpenMPI as well (JuliaPackaging#5180)
  MAGEMin: Require MPItrampoline 5 (JuliaPackaging#5222)
  LAMMPS: Require MPItrampoline 5 (JuliaPackaging#5221)
  CrypoMiniSat: Require MPItrampoline 5 (JuliaPackaging#5219)
  PETSc: Require MPItrampoline 5 (JuliaPackaging#5223)
  [SBML] missing functions patch (JuliaPackaging#5224)
  HYPRE: Require MPItrampoline 5 (JuliaPackaging#5220)
  openPMD_api: Require MPItrampoline 5 (JuliaPackaging#5218)
  COSMA: Simplify configuring OpenMPI (JuliaPackaging#5217)
  AMReX: Require MPItrampoline 5 (JuliaPackaging#5215)
  Register Elfutils executables. (JuliaPackaging#5214)
  Wizard recipe: DDSCAT-v7.3.3 (JuliaPackaging#5210)
  ADIOS2: Require MPItrampoline 5 (JuliaPackaging#5212)
  ...
eschnett added a commit to eschnett/Yggdrasil that referenced this pull request Jul 26, 2022
@eschnett
Merge branch 'master' into eschnett/OpenFOAM-mpitrampoline
35682e9 
* master: (69 commits)
  SCALAPACK32: Support MPItrampoline (JuliaPackaging#5230)
  LaMEM: Support MPItrampoline (JuliaPackaging#5229)
  [VMEC] Update dependency versions (JuliaPackaging#5184)
  [xycewrapper] add julia 1.8 support (JuliaPackaging#5228)
  Elemental: Require MPItrampoline 5, enable OpenMPI (JuliaPackaging#5185)
  P4est: Support MPItrampoline (JuliaPackaging#5163)
  SCALAPACK: Support MPItrampoline (JuliaPackaging#5167)
  iso_codes v4.10.0 (JuliaPackaging#5226)
  PTSCOTCH: Require MPItrampoline 5, and build with OpenMPI as well (JuliaPackaging#5180)
  MAGEMin: Require MPItrampoline 5 (JuliaPackaging#5222)
  LAMMPS: Require MPItrampoline 5 (JuliaPackaging#5221)
  CrypoMiniSat: Require MPItrampoline 5 (JuliaPackaging#5219)
  PETSc: Require MPItrampoline 5 (JuliaPackaging#5223)
  [SBML] missing functions patch (JuliaPackaging#5224)
  HYPRE: Require MPItrampoline 5 (JuliaPackaging#5220)
  openPMD_api: Require MPItrampoline 5 (JuliaPackaging#5218)
  COSMA: Simplify configuring OpenMPI (JuliaPackaging#5217)
  AMReX: Require MPItrampoline 5 (JuliaPackaging#5215)
  Register Elfutils executables. (JuliaPackaging#5214)
  Wizard recipe: DDSCAT-v7.3.3 (JuliaPackaging#5210)
  ...
eschnett added a commit to eschnett/Yggdrasil that referenced this pull request Aug 4, 2022
@eschnett
Merge branch 'master' into eschnett/PARMETIS-mpitrampoline
190a105 
* master: (51 commits)
  LaMEM: Support MPItrampoline (JuliaPackaging#5229)
  [VMEC] Update dependency versions (JuliaPackaging#5184)
  [xycewrapper] add julia 1.8 support (JuliaPackaging#5228)
  Elemental: Require MPItrampoline 5, enable OpenMPI (JuliaPackaging#5185)
  P4est: Support MPItrampoline (JuliaPackaging#5163)
  SCALAPACK: Support MPItrampoline (JuliaPackaging#5167)
  iso_codes v4.10.0 (JuliaPackaging#5226)
  PTSCOTCH: Require MPItrampoline 5, and build with OpenMPI as well (JuliaPackaging#5180)
  MAGEMin: Require MPItrampoline 5 (JuliaPackaging#5222)
  LAMMPS: Require MPItrampoline 5 (JuliaPackaging#5221)
  CrypoMiniSat: Require MPItrampoline 5 (JuliaPackaging#5219)
  PETSc: Require MPItrampoline 5 (JuliaPackaging#5223)
  [SBML] missing functions patch (JuliaPackaging#5224)
  HYPRE: Require MPItrampoline 5 (JuliaPackaging#5220)
  openPMD_api: Require MPItrampoline 5 (JuliaPackaging#5218)
  COSMA: Simplify configuring OpenMPI (JuliaPackaging#5217)
  AMReX: Require MPItrampoline 5 (JuliaPackaging#5215)
  Register Elfutils executables. (JuliaPackaging#5214)
  Wizard recipe: DDSCAT-v7.3.3 (JuliaPackaging#5210)
  ADIOS2: Require MPItrampoline 5 (JuliaPackaging#5212)
  ...
@amontoison amontoison mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschnett @ViralBShah @giordano