Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #133 (Support sortby) #134

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Fix #133 (Support sortby) #134

merged 3 commits into from
Aug 10, 2024

Conversation

dlfivefifty
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (375e53c) to head (da5462c).

Files Patch % Lines
src/eigenSelfAdjoint.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          11       11           
  Lines        1636     1636           
=======================================
  Hits         1572     1572           
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack
Copy link
Member

Let's change the CI settings in a separate PR except possibly the nightly testing if it is failing.

@dlfivefifty
Copy link
Member Author

I reverted CI but that means codecov is not being run. It looks like the function

LinearAlgebra.eigen!(A::SymmetricTridiagonalFactorization; tol = eps(real(eltype(A))), sortby::Union{Function,Nothing}=LinearAlgebra.eigsortby)

is not tested. Since SymmetricTridiagonalFactorization is an internal type do we actually need this function? Or we could just delete it.

@andreasnoack andreasnoack merged commit 81eee0d into master Aug 10, 2024
5 of 6 checks passed
@andreasnoack andreasnoack deleted the dl/sortby branch August 10, 2024 08:40
@andreasnoack
Copy link
Member

I reverted CI but that means codecov is not being run.

Not sure I follow. The results are uploaded here https://app.codecov.io/gh/JuliaLinearAlgebra/GenericLinearAlgebra.jl/commit/81eee0d5e9c00f50a0fe79c761d99ef7373dff2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants