Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes capability to tag function #162

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Add release notes capability to tag function #162

merged 1 commit into from
Dec 19, 2019

Conversation

christopher-dG
Copy link
Member

Closes #161

@davidanthoff davidanthoff merged commit 0a44396 into JuliaLang:master Dec 19, 2019
@davidanthoff
Copy link
Collaborator

Awesome, thanks!

Just out of curiosity, does tag work for you? It mostly works for me, but I feel it is still pretty brittle... For example right now it only works if the git credential manager holds a personal access token, I think... But would be great to hear whether it works on other systems as well, so far I've mostly just used it on my own.

@christopher-dG
Copy link
Member Author

I haven't actually tried it, I don't have anything to register right now. I would agree that brittle is a good word to describe it, some tests and breaking into smaller functions would probably go a long way 😊.

@davidanthoff
Copy link
Collaborator

Yeah, this was very much me just trying to get a first version going :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add release notes option to tag
2 participants