Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precomp: Halve the default number of precompilation tasks in windows to avoid ReadOnlyMemoryError #2366

Merged

Conversation

IanButterworth
Copy link
Sponsor Member

Hopefully a temporary fix for #2323

This will mean precomp will be slower on windows, but still a lot faster than <v1.6

Fixes #2323

@IanButterworth IanButterworth added the backport 1.6 Change should be backported to release-1.6 label Jan 28, 2021
@IanButterworth
Copy link
Sponsor Member Author

IanButterworth commented Jan 28, 2021

Windows users can still investigate increasing the number of tasks back to normal with

ENV["JULIA_NUM_PRECOMPILE_TASKS"] = Sys.CPU_THREADS + 1

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the underlying problem isn't to blame on Pkg and should be fixed upstream?

src/API.jl Outdated Show resolved Hide resolved
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@IanButterworth
Copy link
Sponsor Member Author

I guess the underlying problem isn't to blame on Pkg and should be fixed upstream?

Indeed. Perhaps we can leave JuliaLang/julia#39396 on base as a tracking issue

@KristofferC KristofferC merged commit 320ec76 into JuliaLang:master Jan 28, 2021
@IanButterworth IanButterworth deleted the ib/precomp_windows_half_tasks branch January 28, 2021 21:42
KristofferC pushed a commit to IanButterworth/Pkg.jl that referenced this pull request Jan 28, 2021
…to avoid ReadOnlyMemoryError (JuliaLang#2366)

* halve the default number of precompilation tasks in windows to avoid JuliaLang#2323

Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
(cherry picked from commit 320ec76)
@fredrikekre fredrikekre removed the backport 1.6 Change should be backported to release-1.6 label Feb 9, 2021
@mkitti
Copy link
Contributor

mkitti commented Oct 14, 2021

I was just helping someone on Slack with this kind of issue.

As an extreme, I had to recommend the following which worked.

ENV["JULIA_NUM_PRECOMPILE_TASKS"] = 1

They were using Julia 1.6.3 on "Windows 11 Home Insider Preview Build 22468.rs_prelease.210924-1215"

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, skylake)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompilation failure on Windows with julia 1.6 beta1
4 participants