Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended reading: Dan Zheng's DexLang issue comment #291

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Jan 26, 2021

It just summarizes so many things.
There are no excellent books, but at least we have github issues with excessively long comments.

google-research/dex-lang#454

cc @dan-zheng

docs/src/FAQ.md Outdated Show resolved Hide resolved
@oxinabox oxinabox changed the title Add recommended reading: Dan Zeng's DexLang issue comment Add recommended reading: Dan Zheng's DexLang issue comment Jan 26, 2021
Co-authored-by: Dan Zheng <danielzheng@google.com>
@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #291 (e2649af) into master (37a6fec) will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   89.61%   87.85%   -1.76%     
==========================================
  Files          13       13              
  Lines         462      420      -42     
==========================================
- Hits          414      369      -45     
- Misses         48       51       +3     
Impacted Files Coverage Δ
src/differentials/thunks.jl 56.52% <0.00%> (-7.48%) ⬇️
src/ruleset_loading.jl 94.73% <0.00%> (-3.14%) ⬇️
src/differentials/composite.jl 79.80% <0.00%> (-2.65%) ⬇️
src/rule_definition_tools.jl 93.57% <0.00%> (-0.74%) ⬇️
src/accumulation.jl 96.66% <0.00%> (-0.40%) ⬇️
src/differentials/abstract_zero.jl 93.75% <0.00%> (-0.37%) ⬇️
src/differential_arithmetic.jl 96.15% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a6fec...e2649af. Read the comment docs.

@oxinabox oxinabox merged commit f1fbb4c into master Jan 27, 2021
@oxinabox oxinabox deleted the ox/readdansthing branch January 27, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants