Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Weights #4958

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Generated Weights #4958

merged 6 commits into from
Nov 9, 2023

Conversation

mnaamani
Copy link
Member

@mnaamani mnaamani commented Nov 7, 2023

  • Generated weights on reference hardware.
  • Minor clippy/linter fix - removed unused import in cargo unit test
  • Including hydra v5.0.0-alpha.7 #4959 to test updated hydra in run-runtime-upgrade-test.sh

┆Issue is synchronized with this Asana task by Unito

@mnaamani mnaamani merged commit 9680995 into Joystream:nara Nov 9, 2023
24 checks passed
Copy link
Contributor

@ignazio-bovo ignazio-bovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok:

  • the new extrinsics weight scale (buy/sell_on_amm looks plausible)
  • in the creator token *-transfer extrinsic the metadata parameter now is accounted for and possibly it dominates the output size parameter

besides the metadata weight I don't have any other major remark

Weight::from_parts(100_964_050, 0u64)
.saturating_add(Weight::from_parts(0, 20544))
// Standard Error: 50_287
.saturating_add(Weight::from_parts(11_041_181, 0u64).saturating_mul(o.into()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the metadata seems to be accounted for now...

// Standard Error: 67_129
.saturating_add(Weight::from_parts(12_404_421, 0u64).saturating_mul(a.into()))
// Standard Error: 15_985
.saturating_add(Weight::from_parts(1_124_562, 0u64).saturating_mul(b.into()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why beforehand the metadata weight b wasn't even considered...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants