-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Argus] add auth options to elastic logs config #4752
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR.
I tested the authentication and it works as expected.
I suggested some changes to the hideConfigPath
functionality and mentioned in the reply above (kdembler#1)
Since it's going to be a new release, there are also few additional changes needed:
- Please bump the version in
distributor-node/package.json
to1.2.0
- Please add new entry in
distributor-node/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Allow adding authentication options to Elasticsearch logging so that secured clusters can be used as well.