-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql typegen #4636
graphql typegen #4636
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
For some reason storage-sync tests are failing consistently:
|
I think it's because the QN just doesn't have enough time to process all the |
cli/src/graphql/generated/queries.ts
Outdated
@@ -66,6 +66,7 @@ export type DataObjectInfoFragment = { | |||
video?: Types.Maybe<{ id: string }> | |||
subtitle?: Types.Maybe<{ id: string }> | |||
} | |||
| { __typename: 'DataObjectTypeChannelPayoutsPayload' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type name does not exist in master
branch yet, this is part of ephesus QN. Seems like yarn generate:all
was run while being in the ephesus branch.
Please verify it, also make sure to run yarn build:packages
in the monorepo root, to ensure that old build artifacts aren't used in generating gql schema.ts/queries.ts files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it seems I didn't run build:packages after switching branches, before running yarn generate:all, pushed update which now seems to only update Float -> BigInt types in the schema.ts files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
running
yarn generate:all
in cli, storage-node, distributor-node, and tests/network-tests to update queries.ts and schema.tswhich seems to be something we often forget.