Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs to functions and setup auto-generation of docs #70

Merged
merged 39 commits into from
Feb 22, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

Overview

  • Added a bunch of JSDoc comments to the functions (didn't touch the "type" code yet as waiting for feat: add missing Type type guards #46).
  • Configured typedoc to generate docs from those JSDoc comments.
  • Set up a workflow to automatically upload the generated docs to GitHub Pages after each release.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #70 (612ba6d) into main (6cd0371) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   21.99%   21.99%           
=======================================
  Files          18       18           
  Lines         432      432           
  Branches      171      171           
=======================================
  Hits           95       95           
  Misses        315      315           
  Partials       22       22           
Flag Coverage Δ
4.2.4 21.29% <ø> (ø)
4.3.5 21.52% <ø> (ø)
4.4.4 21.52% <ø> (ø)
latest 21.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/comments.ts 0.00% <ø> (ø)
src/compilerOptions.ts 84.21% <ø> (ø)
src/flags.ts 100.00% <ø> (ø)
src/modifiers.ts 0.00% <ø> (ø)
src/nodes/typeGuards/compound.ts 40.90% <ø> (ø)
src/nodes/typeGuards/single.ts 0.00% <ø> (ø)
src/nodes/typeGuards/union.ts 1.94% <ø> (ø)
src/nodes/utilities.ts 0.00% <ø> (ø)
src/scopes.ts 0.00% <ø> (ø)
src/syntax.ts 91.66% <ø> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 @RebeccaStevens this is fantastic, thanks for sending it in! The site works great and I like the deployment strategy a lot. Also strong +1 to a lot of the customizations in typedoc.json

Mostly requesting changes around removing redundant tags & filling in some more site info.

.github/workflows/release-docs.yml Show resolved Hide resolved
src/comments.ts Outdated Show resolved Hide resolved
knip.jsonc Show resolved Hide resolved
src/comments.ts Outdated Show resolved Hide resolved
src/comments.ts Show resolved Hide resolved
"typedoc-plugin-versions"
],
"readme": "none"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Comment] I have a few miscellaneous feature requests that are definitely not blocking for this PR and probably shouldn't go in it even if they're immediately actionable:

  • Integrating Konamimojisplosion 😁
  • Adding a Ctrl/Cmd+K shortcut for search the way Docusaurus and a lot of other sites / site generators have
  • Adding lint rules around tags: avoiding blank/redundant ones and including useful on exported things

...just posting here so I don't forget them.

typedoc.json Outdated Show resolved Hide resolved
typedoc.json Show resolved Hide resolved
typedoc.json Outdated Show resolved Hide resolved
path: docs/

- name: Deploy to GitHub Pages
uses: actions/deploy-pages@v1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Praise] This is a great .yml file, thank you 😄. I've been meaning to look into GH page deployments for OpenContributionsProject/opencontributionssite#29...

cc @blackgirlbytes, good timing here!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Feb 18, 2023
@RebeccaStevens RebeccaStevens removed the status: waiting for author Needs an action taken by the original poster label Feb 20, 2023
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Show resolved Hide resolved
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
.github/actions/git-config/action.yml Show resolved Hide resolved
src/types/getters.ts Show resolved Hide resolved
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️‍🔥 awesome! Really excited to get this in.

src/nodes/typeGuards/compound.ts Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
typedoc.json Outdated Show resolved Hide resolved
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 This is fantastic, thanks so much @RebeccaStevens! I learned a bunch of things from this PR 😄.

Ready to merge whenever you're happy. 🚀

src/types/utilities.ts Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Outdated Show resolved Hide resolved
.github/DEVELOPMENT.md Show resolved Hide resolved
.github/workflows/release-docs.yml Outdated Show resolved Hide resolved
@RebeccaStevens
Copy link
Collaborator Author

I can't guarantee that the workflow is completely correct. We might have to debug it once this is merged.

@RebeccaStevens RebeccaStevens enabled auto-merge (squash) February 21, 2023 16:14
RebeccaStevens and others added 4 commits February 22, 2023 05:16
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@RebeccaStevens RebeccaStevens enabled auto-merge (squash) February 22, 2023 02:45
@RebeccaStevens
Copy link
Collaborator Author

I can't merge this due to unresolved conversations. I'll resolve them then unresolve them so I can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Documentation: Split API docs out from README.md
2 participants