Fix unhook function if obj._toucheggTracker is undefined #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the "obj._toucheggTracker is undefined" error. This can happen if the extension is run under Wayland as obj._toucheggTracker is not initialized when the extension is enabled however it still tries to unhook it when disabling the extension.
JoseExposito
requested changes
Apr 17, 2024
There was a problem hiding this comment.
This is the same fix I made in #57 (comment)
However, it didn't solve the problem.
The extension is not designed to work on Wayland, so I think it'd be a better idea to not start it at all if a Wayland session is in use.
| @@ -164,6 +164,8 @@ class EntryPoint40Class extends GObject.Object { | |||
|
|
|||
| static unhook(obj) { | |||
| /* eslint-disable no-underscore-dangle, no-param-reassign */ | |||
| if (!obj._toucheggTracker) | |||
There was a problem hiding this comment.
{} are required to make the linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "obj._toucheggTracker is undefined" error. This can happen if the extension is run under Wayland as obj._toucheggTracker is not initialized when the extension is enabled however it still tries to unhook it when disabling the extension.
May fix issue #57