Make GroupActivity.role optional

Jonxslays · Oct 25, 2023 · 6685c42 · 6685c42
1 parent feeea96
commit 6685c42
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/wom/models/groups/models.py b/wom/models/groups/models.py
@@ -395,8 +395,8 @@ class GroupActivity(BaseModel):
     type: GroupActivityType
     """The type of activity that occurred."""
 
-    role: GroupRole
-    """The players role in the group."""
+    role: t.Optional[GroupRole]
+    """The players role in the group, if they have one."""
 
     created_at: datetime
     """The datetime indicating when this activity occurred."""

diff --git a/wom/serializer.py b/wom/serializer.py
@@ -1139,7 +1139,7 @@ def deserialize_group_activity(self, data: DictT) -> models.GroupActivity:
             The requested model.
         """
         activity = models.GroupActivity()
-        activity.role = models.GroupRole.from_str(data["role"])
+        activity.role = models.GroupRole.from_str_maybe(data["role"])
         activity.player = self.deserialize_player(data["player"])
         activity.created_at = self._dt_from_iso(data["createdAt"])
         activity.type = models.GroupActivityType.from_str(data["type"])