Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AURPKGBUILDRepos and Fix Localization Command in Makefile #2313

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Refactor AURPKGBUILDRepos and Fix Localization Command in Makefile #2313

merged 2 commits into from
Nov 20, 2023

Conversation

sosiska
Copy link
Contributor

@sosiska sosiska commented Nov 12, 2023

This PR fixes issue #2305, refactors the AURPKGBUILDRepos function for improved concurrency management, and fixes a critical bug in the Makefile that prevented the make locale command from executing properly. The fix involved correcting the msginit invocation with the --no-translator flag and adding a missing semicolon, which now allows for the proper generation and update of .po files. The successful execution of the updated command is reflected in the regenerated localization files included in this PR.

@sosiska sosiska requested a review from Jguer as a code owner November 12, 2023 12:00
@sosiska sosiska changed the title optimize mutex usage and logging in AURPKGBUILDRepos function Refactor AURPKGBUILDRepos and Fix Localization Command in Makefile Nov 14, 2023
Copy link
Owner

@Jguer Jguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sosiska , can you just rebase and I will merge it

Fix localization script Makefile by adding missing semicolon and --no-translator flag
@sosiska
Copy link
Contributor Author

sosiska commented Nov 15, 2023

@Jguer Done

@Jguer Jguer merged commit 0771ded into Jguer:next Nov 20, 2023
2 checks passed
@sosiska sosiska deleted the patch-1 branch November 22, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants