Fix vertex-blending (Skinning) #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
commented
Feb 18, 2019
hw/xbox/nv2a/nv2a_shaders.c
Outdated
| c, | ||
| output, input, matrix, i, | ||
| (i < (count - 1)) ? "weight_i" : "weight_n", | ||
| swizzle); |
There was a problem hiding this comment.
This code path works only fine for count = 2
JayFoxRox
commented
Feb 18, 2019
hw/xbox/nv2a/nv2a_debug.h
Outdated
| @@ -28,7 +28,7 @@ | |||
| # define NV2A_DPRINTF(format, ...) do { } while (0) | |||
| #endif | |||
|
|
|||
| // #define DEBUG_NV2A_GL | |||
| #define DEBUG_NV2A_GL | |||
There was a problem hiding this comment.
Remove; only trying to make renderdoc work again
JayFoxRox
force-pushed
the
fix-doax-skin
branch
from
c86e1d1
to
bf0a627
Compare
JayFoxRox
force-pushed
the
fix-doax-skin
branch
from
bf0a627
to
57e8387
Compare
|
Upstreamed; was a bug with mode order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make sense of:
I'm trying to fix: https://www.youtube.com/watch?v=6Ufbyr33hKQ
This works fine in Cxbx-R: https://www.youtube.com/watch?v=CU9D3-cLFCI
No success so far.