Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable telemetry client due to incompatibilites with jakarta #8526

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Feb 23, 2022

Quick fix fixes #8525

Tobi will hate me, but we really need to either get rid of it completely or move to version 3.x which comes as an agent.
2.6.x is not working with jpms.
I had to disable it due to #8525 which fails due to Caused by: java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 23, 2022
@calixtus
Copy link
Member

For Tobi's sake, let's make moving to 3.x a priority

@koppor
Copy link
Member

koppor commented Feb 24, 2022

Let's move forward here...

We need an ADR about our telemetry. Somewhere else we discussed about an open source alternative, but negleted it, because Azure just works.

@koppor koppor merged commit a55f1d5 into main Feb 24, 2022
@koppor koppor deleted the telemetry branch February 24, 2022 07:50
@koppor
Copy link
Member

koppor commented Feb 24, 2022

Note on 2.x to 3.x updates: #7161 (comment)

Regarding 2.x errors see microsoft/ApplicationInsights-Java#1060

@koppor
Copy link
Member

koppor commented Feb 24, 2022

Moving to 3.x is filed as issue at #8529

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 24, 2022
@tobiasdiez
Copy link
Member

I don't hate anyone. The telemetry thing has been semi broken anyway so upgrading to v3 is a good idea

Siedlerchr added a commit that referenced this pull request Feb 26, 2022
* upstream/main:
  Add initial telemetry development documentation (#8530)
  Add existing "Remote storage" to index
  Disable telemetry client due to incompatibilites with jakarta (#8526)
Siedlerchr added a commit that referenced this pull request Mar 7, 2022
* upstream/main:
  Bump guava from 31.0.1-jre to 31.1-jre (#8543)
  Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548)
  Bump postgresql from 42.3.2 to 42.3.3 (#8546)
  Bump richtextfx from 0.10.7 to 0.10.9 (#8547)
  Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545)
  Bump actions/checkout from 2 to 3 (#8542)
  Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
  Bump classgraph from 4.8.139 to 4.8.141 (#8535)
  Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536)
  issue(8448): allow URL with + sign in entry tabs (#8508)
  Add initial telemetry development documentation (#8530)
  Add existing "Remote storage" to index
  Disable telemetry client due to incompatibilites with jakarta (#8526)
  Update to jakarta xml everywhere and update PDFbox (#8521)
  Bump flexmark-ext-gfm-tasklist from 0.62.2 to 0.64.0 (#8515)
  Bump xmlunit-core from 2.8.4 to 2.9.0 (#8519)
  Bump org.openjfx.javafxplugin from 0.0.11 to 0.0.12 (#8518)
  Bump mockito-core from 4.3.0 to 4.3.1 (#8520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad install from .deb
4 participants