Upgrade lucence to 9.x with proper JPMS #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
|
Need testing by someone on windows + linux as well with some pdfs. |
|
Im currently in on a short trip, will test on Wednesday. |
|
How would the test look like? |
Have a bib file with linked PDFs. Do a full text search. The search should find something in the text of the PDFs. (Documentation of that feature is still a TODO 😅) |
|
You need the binaries from here https://builds.jabref.org/pull/8362/merge/ |
|
Sorry, fulltext search fails on JabRef 5.5-PullRequest8362.15--2021-12-27--a98ebec Error Log |
|
Thanks, probably missing an additional required from the module info |
|
I still got the error with 814eb0d Error Log |
|
|
Now testedd again, getting a different error: |
* upstream/main: Observable Preferences J (Preview) and minor refactor (#8370) quickfix (#8383) Live reloading when switching themes (#7336) FIX NPE on Merge Dialog (#8380) Bump org.eclipse.jgit from 5.13.0.202109080827-r to 6.0.0.202111291000-r (#8378) Bump jackson-dataformat-yaml from 2.13.0 to 2.13.1 (#8379) Bump tika-core from 2.2.0 to 2.2.1 (#8377) Update turabian-fullnote-bibliography-no-ibid.csl Squashed 'buildres/csl/csl-locales/' changes from d5ee85de8e..c38205618f Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..f78c707
check if index exists
|
It seems to work now, I tested the local jpackage build and this worked now. Would be nice if someone could test with a couple of PDFs |
|
Sorry, i still immediately and for every typing attempt, get an error on JabRef 5.5-PullRequest8362.39--2022-01-04--c6c03ba Have not even tried testing the Linux version yet. Will do, when the windows one works. Error log |
|
Hi! Sorry for the late reply - I was on vacation. Update: turns out I was unlucky with the first search term. Full-text search works fine now. |
Siedlerchr
removed
the
status: ready-for-review
|
Seems like I also had an old version with jpackage. Now I still get the same coded not found error fuu It may have something to do that lucence writes the codecname in the segments file and it was previously differennt? |
Makes sure that all indexes are deleted before switching to lucene 9.
|
Reminder to try with 9.1 |
* upstream/main: (150 commits) fix unit test Add check for developer's documentation Merge GitBook view Fix zbMath fetcher (#8623) GitBook: [#56] No subject Add an extra dialog to ask the user whether they want to open the saved file folder when the export the entries (#8567) Bump checkstyle from 10.0 to 10.1 (#8620) Bump peter-evans/create-pull-request from 3 to 4 (#8619) Bump pascalgn/automerge-action from 0.14.3 to 0.15.2 (#8618) Bump flexmark from 0.62.2 to 0.64.0 (#8621) Bump classgraph from 4.8.141 to 4.8.143 (#8622) update test getPart (#8610) Add ControlHelper truncateString tests comments (#8612) Allow using custom SSL certificates (#8583) Fix protectedTerms not stored due to weaklistener (#8609) Fix changelog and version parsing (#8578) Creating more unit tests for NumericFieldComparatorTest (#8604) Fix merge entries dialog exceeding screen size (#8599) StringUtilTest new test for method GetPart (#8594) Use unkown entry type ... # Conflicts: # build.gradle # src/main/java/org/jabref/logic/pdf/search/retrieval/PdfSearcher.java
Siedlerchr
added
the
status: ready-for-review
|
There seems to be something wrong with the DocumentViewer. Can someone verify this in main? |
|
Bug is noted in #8628 |
|
Fuu! Method too large on windows. Need to investigate if we can reduce this somehow by applying some uses directives. |
Fix exception in document viewer if doc is not pdf
|
Because we have a new version of Lucence I switched the index directory |
2 tasks
|
Does Lucene complain when it finds an old format of the index? Would we need a cleanup then? -- Do we need different directories depending on JabRef's version? Similar to IntelliJ creating a settinsg directory for each version? Feels strange... |
|
Lucence has backwards compatibility codecs. Need to investigate that if it works |
* upstream/main: Remove obsolete comments Improve key generation (#8641) Refine search code (#8636) Fix import entry by id does not generate citation key (#8361) Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637) Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638) GitBook: [#57] test Citation keygen: Return vonPart if lastName is empty (#8634) Ensure SSL truststore is present at startup (#8631) Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632) Add more tests for FieldChange Class (#8614)
|
It is forward compatible, e.g. it can use the old index, but older versions cannot read it then once it was created in a newer version. |
Siedlerchr
added a commit
that referenced
this pull request
Apr 11, 2022
…om.github.tomtung-latex2unicode_2.12-0.3.0 * upstream/main: Bump h2-mvstore from 2.1.210 to 2.1.212 in /buildSrc (#8665) Bump actions/setup-java from 2 to 3 (#8660) Bump hmarr/auto-approve-action from 2.2.0 to 2.2.1 (#8661) Bump unoloader from 7.3.0 to 7.3.2 (#8662) Bump antlr from 3.5.2 to 3.5.3 (#8663) Upgrade lucence to 9.x with proper JPMS (#8362)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more hacking needed. I could compile it and jlink worked locally.
Need to test if the binaries also work.
Fixes koppor#522
Changelog https://lucene.apache.org/core/9_0_0/changes/Changes.html
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)