Refactored UnicodeToLatexFormatterTest #7699
Conversation
| Arguments.of("", ""), // empty string input | ||
| Arguments.of("abc", "abc"), // non unicode input | ||
| Arguments.of("\u00E5\u00E4\u00F6", "{{\\aa}}{\\\"{a}}{\\\"{o}}"), // multiple unicodes input | ||
| Arguments.of("\u0081", ""), // high code point unicode, boundary case: cp = 129 | ||
| Arguments.of("\u0080", ""), // high code point unicode, boundary case: cp = 128 < 129 | ||
| Arguments.of(new UnicodeToLatexFormatter().getExampleInput(), "M{\\\"{o}}nch") |
There was a problem hiding this comment.
Please switch parameters to comply with assertEquals semantics: first the expected, then the input value.
There was a problem hiding this comment.
Code is updated as suggested. :)
Switched the position of argument and expected output to comply with unit test convention
|
@ningxie1991 Maybe, we need to guide you how to read the checkers of GitHub. I marked the required tests:
They are all required. If they are green, they are good to go. If they are yellow, one has to wait (and can do nothing currently). If they are red, one has to work on them. Thus, please work on checkstyle. In case you followed our guidelines to setup the local workspace, Ctrl+Alt+L should reformat the code properly. |
Siedlerchr
added
the
status: changes required
|
We closed the PR, because there was no activity and the changes were rather small. In case you are still interested in contributing, please try to work on another issue. |
|
I fixed the checkstlye issue and merged it 0c8662e |
Really sorry that I lost track of this pull request. I will make sure required tests pass in future pull request. |
Thank you so much! |
This pull request contributes to issue #6207, which is to add more unit tests or improve existing ones. I used Pitest to compute the line and mutation coverage. The empty string input was missing in the test, as well as the boundary case test for high code point unicode inputs.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)