Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor simple Unit Tests #7571

Merged
merged 12 commits into from
May 6, 2021
Merged

Refactor simple Unit Tests #7571

merged 12 commits into from
May 6, 2021

Commits on Mar 24, 2021

  1. Configuration menu
    Copy the full SHA
    93a97bc View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Configuration menu
    Copy the full SHA
    9c62748 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. fix typos

    Davfon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    4d11f5f View commit details
    Browse the repository at this point in the history
  2. move formatter creation out of @beforeeach

    It is unnecessary to create a new formatter for each test.
    ("test smell": General Fixture / Test Code Duplication)
    
    renamed UnicodeConverterTest to UnicodeConverterFormatterTest
    Davfon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    5ef25ef View commit details
    Browse the repository at this point in the history
  3. move formatter creation out of @beforeeach

    It is unnecessary to create a new formatter for each test.
    ("test smell": General Fixture / Test Code Duplication)
    Davfon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e9aa9b3 View commit details
    Browse the repository at this point in the history
  4. move formatter creation out of @beforeeach

    It is unnecessary to create a new formatter for each test.
    ("test smell": General Fixture / Test Code Duplication)
    Davfon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    3563a1b View commit details
    Browse the repository at this point in the history
  5. remove unnecessary @beforeeach & @AfterEach

    It is unnecessary to create a new comparator before each test and setting it to null after each test.
    ("test smell": General Fixture / Test Code Duplication)
    Davfon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    7e4a486 View commit details
    Browse the repository at this point in the history
  6. convert to Parameterized Tests

    test code quality improvement
    ("test smell": Test Code Duplication)
    easier to maintain, less risk of error propagation.
    Davfon committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    98004a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Configuration menu
    Copy the full SHA
    94d4625 View commit details
    Browse the repository at this point in the history
  2. BibtexCaseChangersTest & BibtexPurifyTest

    - remove unmeaningful comment
    - testSpecialBracketPlacement
    - add disabled for commented code
    - integrate assertion in testPurify
    Davfon committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    50420b9 View commit details
    Browse the repository at this point in the history
  3. Fix CheckStyle

    Davfon committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    a23e989 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Configuration menu
    Copy the full SHA
    a30c0d5 View commit details
    Browse the repository at this point in the history