Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing trigger for linked file operations #7548

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Mar 17, 2021

Fixes #7525

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@calixtus calixtus changed the title Fixed missing trigger Fixed missing trigger for linked file operations Mar 17, 2021
@tobiasdiez
Copy link
Member

I was also looking at this, and got confused why there is a binding to the executable state in the first place. The context menu is created when the user right clicks the file, and then the state doesn't change until the user chooses a an option from the menu. Moreover, the linked file view model should be recreated as soon as the content of the file field changes - so no binding needed since the linkedfile is constant for all practical purposes. What I am missing?

@calixtus
Copy link
Member Author

I have no idea, but it works... 😅

But seriously: The ContextAction command was introduced in the first place to prepare this for a later to be added undo functionality. I tried it also with BindingsHelper.constantOf() and directly with setExecutable() but this did not show a consistent behaviour, my guess is that something is still cached.

In this state I think it works, but some more investigation surely wouldn't hurt.

@tobiasdiez
Copy link
Member

Yeah, I'm also afraid that it is actually a cache error and it still shows the context menu for the previous version of the linked file. Hopefully that doesn't lead to more problems, e.g. when the action is performed with respect to the previous version instead of the current one.

@calixtus calixtus marked this pull request as ready for review March 17, 2021 21:00
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 17, 2021
@Siedlerchr Siedlerchr merged commit 303018f into master Mar 18, 2021
@Siedlerchr Siedlerchr deleted the fix-7527 branch March 18, 2021 12:32
Siedlerchr added a commit that referenced this pull request Mar 28, 2021
* upstream/master: (191 commits)
  Fix for issue 7416: font size of the preferences dialog does not update with the rest of the GUI. (#7509)
  Fix school/instituation is printed twice (#7574)
  Dsiable notarisation until we hae an account for JabRef e.V. (#7572)
  Fix citation keys unintentionally being overwritten on import (#7443)
  Fix AuthentificationPlugin not declared in mergedModule (#7570)
  Suggestions for changes in caching latex free authors (#7301)
  Add simple Unit Tests (#7542)
  Fix drag and drop into empty library (#7555)
  Bump richtextfx from 0.10.4 to 0.10.6 (#7563)
  Bump pdfbox from 2.0.22 to 2.0.23 (#7561)
  Bump org.eclipse.jgit (#7560)
  Bump fontbox from 2.0.22 to 2.0.23 (#7562)
  Bump guava from 30.1-jre to 30.1.1-jre (#7564)
  Bump xmpbox from 2.0.22 to 2.0.23 (#7565)
  Bump hmarr/auto-approve-action from v2.0.0 to v2.1.0 (#7566)
  Add gource (#7193)
  UI: Fix for group icon (#7552)
  Fix for issue 6487: Opening BibTex file (doubleclick) from Folder with spaces not working (#7551)
  add ability to insert arxivId (#7549)
  Fixed missing trigger for linked file operations (#7548)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File renaming functions are greyed out (deactivated) for unclear reasons
3 participants