Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to javafx 16 #7512

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Update to javafx 16 #7512

merged 1 commit into from
Mar 11, 2021

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Mar 10, 2021

https://github.com/openjdk/jfx/blob/master/doc-files/release-notes-16.md

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 10, 2021
@tobiasdiez
Copy link
Member

Cool! It is working without a problem locally?

Could you please also revert #5497 since the javafx bug is now fixed. According to #5226 that's the only issue that was waiting on a javafx update.

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Mar 11, 2021

Reverting #5497 would create a merge conflict with #7336
Worked fine locally

@Siedlerchr Siedlerchr merged commit 2c784e6 into master Mar 11, 2021
@Siedlerchr Siedlerchr deleted the openjfx16 branch March 11, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants