Added Keyboard shortcuts (clear/set read status) #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear read status (alt+C) Set read status to read (alt+R) Set read status to skimmed (alt+S)
Siedlerchr
approved these changes
Jan 6, 2021
|
ups, thought i had to close the pull request but i think i have to wait until you merge it. |
koppor
requested changes
Jan 6, 2021
| @@ -105,7 +105,10 @@ | |||
| UNDO("Undo", Localization.lang("Undo"), "ctrl+Z", KeyBindingCategory.EDIT), | |||
| WEB_SEARCH("Web search", Localization.lang("Web search"), "alt+4", KeyBindingCategory.SEARCH), | |||
| WRITE_XMP("Write XMP", Localization.lang("Write XMP"), "F6", KeyBindingCategory.TOOLS), | |||
| CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE", KeyBindingCategory.SEARCH); | |||
| CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE", KeyBindingCategory.SEARCH), | |||
| CLEAR_READ_STATUS("Clear read status", Localization.lang("Clear read status"), "alt+C", KeyBindingCategory.EDIT), | |||
There was a problem hiding this comment.
I am not sure whether this is a good default.
Typically, in an application, there are shortcut keys for menu entries. They are typically used by Alt and then the letter. This is the same pattern than you propose. See also https://www.howtogeek.com/366147/how-to-make-windows-10-underline-and-highlight-menu-shortcut-keys/.
See for instance Excel:
We are trying to bring them back into JabRef.
Could you please think of other shortcuts? Maybe Ctrl+Alt+X?
There was a problem hiding this comment.
okay, how about:
- clear: ctrl+alt+x
- read: ctrl+alt+r
- skimmed: ctrl+alt+d (ctrl+alt+s is "Save all")
There was a problem hiding this comment.
I think it would also be fine to have no default values.
Siedlerchr
added
the
status: ready-for-review
|
If everybody is happy, I'll think I merge. Thanks! 😄 |
koppor
added
keybinding
ui
and removed
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Jan 7, 2021
…dtask * upstream/master: Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 Adapt workflow and build.gradle Move CSL to buildres/csl to speedup "processResources" during development
Siedlerchr
added a commit
that referenced
this pull request
Jan 10, 2021
* upstream/master: (34 commits) Fixed exception about missing custom css file (#7292) Update the templates for opening a new issue (#7321) Entitlements file Mac (#7317) Make CONTRIBUTING.md much shorter. Move long text to docs/contributing.md (#7293) Include Github-optimized screenshot into repository (#7318) Remove obsolete registry patch file (#7316) Fix AUTHORS GitBook: [master] one page modified Remove broken Sonarqube integration (#7315) GitBook: [master] 5 pages and 32 assets modified docs: update license year (#7314) Add javafx version number + update javafx (#7312) Add missing authors Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Keyboard shortcuts with defaults for
Fixes #7264