Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes missing library properties context menu on library tab #6508

Merged
merged 2 commits into from
May 26, 2020
Merged

Fixes missing library properties context menu on library tab #6508

merged 2 commits into from
May 26, 2020

Conversation

Oltman-B
Copy link
Contributor

@Oltman-B Oltman-B commented May 22, 2020 •
edited by calixtus
Loading

fixes issue #6485 to implement context menu on library tabs
with the "Library properties" menu item.

image

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Oltman-B
Fixes missing library properties context menu on library tab
61453d8 
fixes issue JabRef#6485 to implement context menu on library tabs
with the "Library properties" menu item.
@calixtus
Copy link
Member

Hi @Oltman-B, thank you for your effort in creating this pull request. Codewise it looks good to me.

However, I think the right click menu itself is something, we really should discuss with the other developers, since this is a bit controversial. At least for me. 😉

@koppor
Copy link
Member

koppor commented May 26, 2020

JabRef 3.8.2:

grafik

@Oltman-B Could you (re-)add this functionality, too?

@koppor
Copy link
Member

koppor commented May 26, 2020

Thank you for the PR. We will go ahead with merging!

We created a follow-up issue at #6527 - and would be happy if you worked on it 🌮

@koppor koppor merged commit 0d7156b into JabRef:master May 26, 2020
Siedlerchr added a commit that referenced this pull request May 26, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into autoinstall_ext
da01d55 
* upstream/master: (76 commits)
  Fixes missing library properties context menu on library tab (#6508)
  Bump flexmark-ext-gfm-strikethrough from 0.61.30 to 0.61.32
  Bump archunit-junit5-api from 0.13.1 to 0.14.1
  Bump flexmark from 0.61.30 to 0.61.32
  Bump flexmark-ext-gfm-tasklist from 0.61.30 to 0.61.32
  Add javadoc and fix the preview update issue
  Refactor externalprefs (#6509)
  Extend the bib file for better screenshots
  Remove Grobid also from tests
  Fix help file tests
  Update ActionHelper.java
  Adjusted fix by using StateManager for clearing search bar
  fix checkstyle
  Return true in action helper if file is online link
  Reenable caching of gradle
  Refactor BibtexKeyPatternPreferences (#6489)
  Update CHANGELOG.md
  Add changelog entry and remove unnecessary code
  EasyBind revision part two
  Fix Drag and Drop on empty database
  ...
@Oltman-B Oltman-B deleted the implement-context-menu-library-tab-issue-6485 branch May 26, 2020 20:29
@Oltman-B
Copy link
Contributor Author

JabRef 3.8.2:

grafik

@Oltman-B Could you (re-)add this functionality, too?

Thank you! Since making this commit, I decided to start working in .NET, so I removed my Java dev tools for the time being. If I get some extra time I'd like to work on the related issue, but if anybody else wants to take it, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oltman-B @calixtus @koppor @Siedlerchr