-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement task progress indicator (and dialog) in the toolbar #6443
Commits on May 7, 2020
-
First draft of a task progress dialog
Implemented a task progress dialog using a TaskProgressView. Tasks show up, but without info. Neither the progress nor title and message are shown.
Configuration menu - View commit details
-
Copy full SHA for fdfe074 - Browse repository at this point
Copy the full SHA fdfe074View commit details -
Added progress indicator in JabRefFrame
There now i a progress indicator at the rightmost postition of JabRefs toolbar. It shows the average progress of all running background tasks. Clicking it will show a TaskProgressDialog. still looks ugly and the binding to the average progress does not seem to be working.
Configuration menu - View commit details
-
Copy full SHA for 6fd1811 - Browse repository at this point
Copy the full SHA 6fd1811View commit details
Commits on May 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b883491 - Browse repository at this point
Copy the full SHA b883491View commit details -
Changed to Task<?> in the Tasklist.
This makes the view work with download tasks for example. Most other tasks are still shown without title, message (because none are set) and progress. Also, there are a lot of tasks somehow. The progress indicator in the main view still does not work as I can't get the bindings to work.
Configuration menu - View commit details
-
Copy full SHA for 255a6e4 - Browse repository at this point
Copy the full SHA 255a6e4View commit details -
Resolved typing issues for bindings
The progress indicator is now successfully bound to the list of tasks. However, tasks do not show up in the dialogue any more.
Configuration menu - View commit details
-
Copy full SHA for 38dd89d - Browse repository at this point
Copy the full SHA 38dd89dView commit details -
Converted list of Properties to tasks for listbind
When using ObjectProperties in the list of tasks, we can use EasyBind to convert the list into a list of tasks which in turn can be bound to the list of tasks in the view. With this, the basic functionality works. There is a progress indicator in the toolbar that shows the average progress of all running background tasks. It is indeterminate if any task has indeterminate progress and shows 100% if no tasks are running. Clicking it opens an overview of all running tasks and their progress. Currently, there are many tasks running all the time. The only tasks that were adapted for this to be pretty are the download tasks, and they are also still missing an icon.
Configuration menu - View commit details
-
Copy full SHA for 1b2aaa6 - Browse repository at this point
Copy the full SHA 1b2aaa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for baf9bd0 - Browse repository at this point
Copy the full SHA baf9bd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40a8feb - Browse repository at this point
Copy the full SHA 40a8febView commit details -
Configuration menu - View commit details
-
Copy full SHA for cac989b - Browse repository at this point
Copy the full SHA cac989bView commit details -
Better messages for download tasks
These are shorter and therefore the task progress view does not need a horizontal scroll bar.
Configuration menu - View commit details
-
Copy full SHA for 8f525b8 - Browse repository at this point
Copy the full SHA 8f525b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c877431 - Browse repository at this point
Copy the full SHA c877431View commit details
Commits on May 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1ad9598 - Browse repository at this point
Copy the full SHA 1ad9598View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd4e38e - Browse repository at this point
Copy the full SHA cd4e38eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f8cf0 - Browse repository at this point
Copy the full SHA 23f8cf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4628c3d - Browse repository at this point
Copy the full SHA 4628c3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90ff19e - Browse repository at this point
Copy the full SHA 90ff19eView commit details -
Make showProgressDialogAndWait actually not only show but also wait.
Configuration menu - View commit details
-
Copy full SHA for 62d7c14 - Browse repository at this point
Copy the full SHA 62d7c14View commit details
Commits on May 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 008d55e - Browse repository at this point
Copy the full SHA 008d55eView commit details -
More informative (and working) quit dialog
The dialog that is shown when the user quits JabRef during ongoing background tasks now shows which background tasks are still running. When all of them complete or the user chooses to quit anyway, JabRef quits. The user can also cancel the dialog. In that case, the dialog closes and JobRef remains running.
Configuration menu - View commit details
-
Copy full SHA for a9f4493 - Browse repository at this point
Copy the full SHA a9f4493View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ac316 - Browse repository at this point
Copy the full SHA 66ac316View commit details -
There are still some ImportOrder errors though where I can see no issue.
Configuration menu - View commit details
-
Copy full SHA for e9a7176 - Browse repository at this point
Copy the full SHA e9a7176View commit details -
Registered the save task as background task
This makes the dialog that pops up if background tasks are running wait for pending saves.
Configuration menu - View commit details
-
Copy full SHA for d7442cc - Browse repository at this point
Copy the full SHA d7442ccView commit details -
Revert "Registered the save task as background task"
This reverts commit d7442cc.
Configuration menu - View commit details
-
Copy full SHA for 5defe3e - Browse repository at this point
Copy the full SHA 5defe3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fba9c70 - Browse repository at this point
Copy the full SHA fba9c70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a62e6f - Browse repository at this point
Copy the full SHA 6a62e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a97af13 - Browse repository at this point
Copy the full SHA a97af13View commit details -
Merge branch 'master' of https://github.com/JabRef/jabref into featur…
…e/backgroundProgress
Configuration menu - View commit details
-
Copy full SHA for 3ee4571 - Browse repository at this point
Copy the full SHA 3ee4571View commit details
Commits on May 11, 2020
-
Quickfix for resizing indicator when indeterminate
Set the pref-width when the indicator is determinate to keep the indeterminate state from making the indicator wider.
Configuration menu - View commit details
-
Copy full SHA for 44d9ca8 - Browse repository at this point
Copy the full SHA 44d9ca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd2eefd - Browse repository at this point
Copy the full SHA bd2eefdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41efc04 - Browse repository at this point
Copy the full SHA 41efc04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c9ccea - Browse repository at this point
Copy the full SHA 2c9cceaView commit details -
Removed WaitForBackgroundtasksFinishedDialog
More in line with the other JabRef dialogs Addresses JabRef#6443 (comment)
Configuration menu - View commit details
-
Copy full SHA for ff9ce00 - Browse repository at this point
Copy the full SHA ff9ce00View commit details -
Configuration menu - View commit details
-
Copy full SHA for d56138b - Browse repository at this point
Copy the full SHA d56138bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf10859 - Browse repository at this point
Copy the full SHA cf10859View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcb1d0c - Browse repository at this point
Copy the full SHA fcb1d0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 396411a - Browse repository at this point
Copy the full SHA 396411aView commit details
Commits on May 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e24c141 - Browse repository at this point
Copy the full SHA e24c141View commit details -
Configuration menu - View commit details
-
Copy full SHA for 478ee05 - Browse repository at this point
Copy the full SHA 478ee05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0557c67 - Browse repository at this point
Copy the full SHA 0557c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23b7e69 - Browse repository at this point
Copy the full SHA 23b7e69View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ae796 - Browse repository at this point
Copy the full SHA e3ae796View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db3997 - Browse repository at this point
Copy the full SHA 3db3997View commit details