Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement task progress indicator (and dialog) in the toolbar #6443

Merged
merged 42 commits into from
May 12, 2020

Commits on May 7, 2020

  1. First draft of a task progress dialog

    Implemented a task progress dialog using a TaskProgressView.
    Tasks show up, but without info. Neither the progress nor title and
    message are shown.
    btut committed May 7, 2020
    Configuration menu
    Copy the full SHA
    fdfe074 View commit details
    Browse the repository at this point in the history
  2. Added progress indicator in JabRefFrame

    There now i a progress indicator at the rightmost postition of JabRefs
    toolbar. It shows the average progress of all running background tasks.
    Clicking it will show a TaskProgressDialog.
    
    still looks ugly and the binding to the average progress does not seem
    to be working.
    btut committed May 7, 2020
    Configuration menu
    Copy the full SHA
    6fd1811 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Configuration menu
    Copy the full SHA
    b883491 View commit details
    Browse the repository at this point in the history
  2. Changed to Task<?> in the Tasklist.

    This makes the view work with download tasks for example. Most other
    tasks are still shown without title, message (because none are set) and
    progress.
    Also, there are a lot of tasks somehow.
    
    The progress indicator in the main view still does not work as I can't
    get the bindings to work.
    btut committed May 8, 2020
    Configuration menu
    Copy the full SHA
    255a6e4 View commit details
    Browse the repository at this point in the history
  3. Resolved typing issues for bindings

    The progress indicator is now successfully bound to the list of tasks.
    However, tasks do not show up in the dialogue any more.
    btut committed May 8, 2020
    Configuration menu
    Copy the full SHA
    38dd89d View commit details
    Browse the repository at this point in the history
  4. Converted list of Properties to tasks for listbind

    When using ObjectProperties in the list of tasks, we can use EasyBind to
    convert the list into a list of tasks which in turn can be bound to the
    list of tasks in the view.
    
    With this, the basic functionality works. There is a progress indicator
    in the toolbar that shows the average progress of all running background
    tasks. It is indeterminate if any task has indeterminate progress and
    shows 100% if no tasks are running.
    
    Clicking it opens an overview of all running tasks and their progress.
    
    Currently, there are many tasks running all the time. The only tasks
    that were adapted for this to be pretty are the download tasks, and they
    are also still missing an icon.
    btut committed May 8, 2020
    Configuration menu
    Copy the full SHA
    1b2aaa6 View commit details
    Browse the repository at this point in the history
  5. New Tasks are first in the list

    btut committed May 8, 2020
    Configuration menu
    Copy the full SHA
    baf9bd0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    40a8feb View commit details
    Browse the repository at this point in the history
  7. Only show download tasks

    btut committed May 8, 2020
    Configuration menu
    Copy the full SHA
    cac989b View commit details
    Browse the repository at this point in the history
  8. Better messages for download tasks

    These are shorter and therefore the task progress view does not need a
    horizontal scroll bar.
    btut committed May 8, 2020
    Configuration menu
    Copy the full SHA
    8f525b8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c877431 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Added extractor to task list

    btut committed May 9, 2020
    Configuration menu
    Copy the full SHA
    1ad9598 View commit details
    Browse the repository at this point in the history
  2. Made anyTaskRunningBinding public

    For consistency with other variables
    btut committed May 9, 2020
    Configuration menu
    Copy the full SHA
    cd4e38e View commit details
    Browse the repository at this point in the history
  3. Removed ObjectProperty wrapping

    btut committed May 9, 2020
    Configuration menu
    Copy the full SHA
    23f8cf0 View commit details
    Browse the repository at this point in the history
  4. NOT WORKING: quit dialogue

    btut committed May 9, 2020
    Configuration menu
    Copy the full SHA
    4628c3d View commit details
    Browse the repository at this point in the history
  5. Cleanup

    btut committed May 9, 2020
    Configuration menu
    Copy the full SHA
    90ff19e View commit details
    Browse the repository at this point in the history
  6. Fix in dialog service

    Make showProgressDialogAndWait actually not only show but also wait.
    btut committed May 9, 2020
    Configuration menu
    Copy the full SHA
    62d7c14 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Add extractor for isRunning

    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    008d55e View commit details
    Browse the repository at this point in the history
  2. More informative (and working) quit dialog

    The dialog that is shown when the user quits JabRef during ongoing
    background tasks now shows which background tasks are still running.
    
    When all of them complete or the user chooses to quit anyway, JabRef
    quits.
    
    The user can also cancel the dialog. In that case, the dialog closes and
    JobRef remains running.
    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    a9f4493 View commit details
    Browse the repository at this point in the history
  3. Added graphics callback

    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    66ac316 View commit details
    Browse the repository at this point in the history
  4. Fixed some style issues

    There are still some ImportOrder errors though where I can see no issue.
    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    e9a7176 View commit details
    Browse the repository at this point in the history
  5. Registered the save task as background task

    This makes the dialog that pops up if background tasks are running wait
    for pending saves.
    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    d7442cc View commit details
    Browse the repository at this point in the history
  6. Revert "Registered the save task as background task"

    This reverts commit d7442cc.
    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    5defe3e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fba9c70 View commit details
    Browse the repository at this point in the history
  8. Updated changelog

    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    6a62e6f View commit details
    Browse the repository at this point in the history
  9. Fixed style

    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    a97af13 View commit details
    Browse the repository at this point in the history
  10. Merge branch 'master' of https://github.com/JabRef/jabref into featur…

    …e/backgroundProgress
    btut committed May 10, 2020
    Configuration menu
    Copy the full SHA
    3ee4571 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Quickfix for resizing indicator when indeterminate

    Set the pref-width when the indicator is determinate to keep the
    indeterminate state from making the indicator wider.
    btut committed May 11, 2020
    Configuration menu
    Copy the full SHA
    44d9ca8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd2eefd View commit details
    Browse the repository at this point in the history
  3. Minor style fix

    btut committed May 11, 2020
    Configuration menu
    Copy the full SHA
    41efc04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c9ccea View commit details
    Browse the repository at this point in the history
  5. Removed WaitForBackgroundtasksFinishedDialog

    More in line with the other JabRef dialogs
    Addresses JabRef#6443 (comment)
    btut committed May 11, 2020
    Configuration menu
    Copy the full SHA
    ff9ce00 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d56138b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cf10859 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fcb1d0c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    396411a View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Fixed progress-indicator styling

    btut committed May 12, 2020
    Configuration menu
    Copy the full SHA
    e24c141 View commit details
    Browse the repository at this point in the history
  2. Improve getIcon method

    tobiasdiez committed May 12, 2020
    Configuration menu
    Copy the full SHA
    478ee05 View commit details
    Browse the repository at this point in the history
  3. Well, I said hopefully ;-)

    tobiasdiez committed May 12, 2020
    Configuration menu
    Copy the full SHA
    0557c67 View commit details
    Browse the repository at this point in the history
  4. Revert "Well, I said hopefully ;-)"

    This reverts commit 0557c67.
    btut committed May 12, 2020
    Configuration menu
    Copy the full SHA
    23b7e69 View commit details
    Browse the repository at this point in the history
  5. Revert "Improve getIcon method"

    This reverts commit 478ee05.
    btut committed May 12, 2020
    Configuration menu
    Copy the full SHA
    e3ae796 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3db3997 View commit details
    Browse the repository at this point in the history