Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StartupWMClass #6398

Merged
merged 1 commit into from
May 3, 2020
Merged

Fix StartupWMClass #6398

merged 1 commit into from
May 3, 2020

Conversation

HifeFish
Copy link
Contributor

@HifeFish HifeFish commented May 2, 2020

Changed StartupWMClass entry in /buildres/linux/JabRef.desktop from org-jabref-JabRefMain to org.jabref.JabRefMain.

Fixes #6396

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez
Copy link
Member

Thanks @HifeFish for the fix.

@LyzardKing what do you think? You've introduced StartupWMClass=org-jabref-JabRefMain in #5444, so I guess there was a reason for the the dash.

@LyzardKing
Copy link
Collaborator

LyzardKing commented May 3, 2020 •
edited
Loading

It might have changed. xprop now shows it with a . instead of the dash.
I distinctly remember having to set a dash, but it might have been a change in jpackage.
Seems like this change is needed now. Good catch!

@tobiasdiez
Copy link
Member

Ok, thanks for the quick feedback.

@HifeFish thanks for taking the initiative to provide a fix for your own issue. Much appreciated and we are looking forward to your next PR!

@tobiasdiez tobiasdiez merged commit bd9f4a5 into JabRef:master May 3, 2020
Siedlerchr added a commit that referenced this pull request May 9, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master'
ded2a2a 
* upstream/master:
  Added a download checkbox to the import dialog (#6381)
  Bump jaxb-xjc from 2.3.2 to 2.3.3 (#6410)
  Bump flexmark-ext-gfm-strikethrough from 0.61.20 to 0.61.24 (#6413)
  Bump byte-buddy-parent from 1.10.9 to 1.10.10 (#6408)
  Bump flexmark-ext-gfm-tasklist from 0.61.20 to 0.61.24 (#6412)
  Bump org.beryx.jlink from 2.17.8 to 2.18.0 (#6411)
  Bump tika-core from 1.24 to 1.24.1 (#6409)
  Bump flexmark from 0.61.20 to 0.61.24 (#6416)
  Bump classgraph from 4.8.77 to 4.8.78 (#6414)
  Restore some missing keyboard shortcuts (#6406)
  Fix StartupWMClass (#6398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StartupWMclass org.jabref.JabRefMain vs org-jabref-JabRefMain
3 participants
@HifeFish @tobiasdiez @LyzardKing