Refine checkstyle rules #6283
Merged
Refine checkstyle rules #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add (and apply) checkstyle rules for
- correct spacing (especalliy // space-after-comment-marker)
- } else if { (<-- in one line)
- no two empty lines
- @Deprecation JavaDoc
- some coding practices
- Fix HTML syntax of JavaDoc comments
- Remove CSS class comment syntax in IconTheme class
- Remove deprecated method BibEntry#getCiteKey()
koppor
force-pushed
the
checkstyle-comment
branch
from
464f044
to
f4b8e7b
Compare
Siedlerchr
requested changes
Apr 13, 2020
| @@ -192,71 +192,71 @@ public static URL getIconUrl(String name) { | |||
| RANK3(MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR_OUTLINE, MaterialDesignIcon.STAR_OUTLINE), | |||
| RANK4(MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR_OUTLINE), | |||
| RANK5(MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR, MaterialDesignIcon.STAR), | |||
| WWW(MaterialDesignIcon.WEB) /*css: web*/, | |||
There was a problem hiding this comment.
I fear removing this comments is a bad idea
There was a problem hiding this comment.
The comments in this source file were the always (!) the same as the reference to the icon. I see no reason why we should duplicate constant names.
There was a problem hiding this comment.
In case you can explain to me the sence of these comments, I can re-add them. All of them formatted the same way. I have the regexp ready.
I sat side-by-side by @matthiasgeiger when he worked on the icons at JabCon 2017. I think, they had to be used at that time when constants in the library were missing (and we had to adress the icon names by numbers (!)). Today, I see no reason to have them here.
koppor
force-pushed
the
checkstyle-comment
branch
from
44b0cd1
to
c08b1a0
Compare
Merged
Merged
koppor
pushed a commit
that referenced
this pull request
Apr 15, 2023
4728902faa Create wiley-was.csl (#6283) 5853909f89 Create journal-of-human-nutrition-and-dietetics.csl (#6311) 286a3606c1 Create stanovnistvo.csl (#6431) 22a7139dc5 Update zitierguide-leitfaden-zum-fachgerechten-zitieren-in-rechtswiss… (#6489) e51e9363ee Update netherlands-journal-of-geosciences-geologie-en-mijnbouw.csl (#6493) 4e1a69231c Add Bristol UP dependents (auto-generated) (#6494) c9021437a4 Create microbiome-research-reports.csl (#6371) f71e516dda Update harvard-anglia-ruskin-university.csl (#6365) c187663e75 Create publicatiewijzer.csl (#6316) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 4728902faa1ef43c0d89366c77b7ea8f46c6730f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit annoyed that I had to comment on code style at code reviews. Bots should take care of this.
Formatting
NOT
Comments
// textNOT
//textSpacing
NOT
In other words
Could not fix all my issues (refs sevntu-checkstyle/sevntu.checkstyle#457), but I thought, I should push this intermediate result to move on and to reduce our reviewing load.