Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not escaping special characters in search pattern #5938

Merged
merged 5 commits into from
Feb 14, 2020
Merged

Fix not escaping special characters in search pattern #5938

merged 5 commits into from
Feb 14, 2020

Commits on Feb 11, 2020

  1. Fix not escaping special characters in search pattern 

    fixes JabRef#5892

* add method to get search pattern for searched words with escaped
 javascript regexp special characters (for search without regular
 expressions)

* in preview viewer use search pattern with escaped javascript regexp
 special characters
    @dawidm
    dawidm committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    2f68520 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Refactoring and performance improvement 

    * use enum to specify special characters escape mode

* use compiled regex pattern instead of string
    @dawidm
    dawidm committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    5c2925d View commit details
    Browse the repository at this point in the history

  2. Refactoring: braces in if..else

    @dawidm
    dawidm committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    89c72c0 View commit details
    Browse the repository at this point in the history

  3. Refactoring, minor changes: names, comments

    @dawidm
    dawidm committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    6f39cbc View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Add tests of escaping special characters in search patterns

    @dawidm
    dawidm committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    266bfc8 View commit details
    Browse the repository at this point in the history