Remove JavaFX-Font-Tweak #5330
Merged
Remove JavaFX-Font-Tweak #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the original author of #3305, @halirutan could you please check if this font tweak is still necessary? Thanks a lot! |
|
@tobiasdiez Yes I can, but I'm not at home on my Linux mache until the weekend. But then, I can have a look. |
Siedlerchr
added
the
status: waiting-for-feedback
|
@halirutan Have you already found the time to look at this? |
|
@tobiasdiez I looked at this tonight and I cannot see a difference between the tweak turned on or off. So I guess it can be removed. |
|
Thanks for having a look at this @halirutan |
tobiasdiez
removed
the
status: waiting-for-feedback
calixtus
added a commit
to calixtus/jabref
that referenced
this pull request
Oct 14, 2019
tobiasdiez
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Initial * Fix special key, refactor visual appearance, l10n * Fixed Indent and wrong value set * Refurbished css * Added BibtexKeyPatternTable, fixed bugs * Fixed bugs in reset, added reset all * Refactored by PR-suggestions, added jumpToPressedKey, highlite default column, set defaultItem to top of list, * l10n * Changelog * Fixed pattern saving, converted default to property * Changed comments * Added help button * Removed fontTweaksLinux according to PR #5330 * l10n * Changed font size limits
koppor
pushed a commit
that referenced
this pull request
Mar 29, 2021
e1acabe Upload Styles (#5351) d9cbf08 Update and rename journal-of-eta-maritime-science.csl to dependent/journal-of-eta-maritime-science.csl (#5353) 988ecca Update clinical-and-translational-immunology.csl (#5348) 1691078 Update molecular-plant-pathology.csl (#5349) 932a5bf Create neurospine.csl (#5334) d663ffc Update sylwan.csl (#5341) b7be05d Update pakistan-journal-of-agricultural-sciences.csl (#5343) d742832 Please rename to Tijdschrift-voor-geneeskunde-en-gezondheidszorg (#5344) 6c6be4d Update et-al settings for journal-of-the-american-society-of-nephrology.csl (#5333) 0263204 Correct citation format of numeric AOSIS styles (#5335) e4cd348 Create the-horticulture-journal.csl (#5327) 5804a6f Add AOSIS dependents (#5332) 2b4510b Create natura-croatia.csl (#5328) 03c6789 Create groundwater.csl (#5329) e08fa09 Create hystrix-the-italian-journal-of-mammalogy.csl (#5330) 1d730aa update page-range-format for Anglia (#5331) 9bb8724 Sort American Physiological Society citation style according to updated author instructions (#5305) a8b53ca Create african-online-scientific-information-systems-vancouver.csl (#5326) c7d8f90 Update yozgat-bozok-universitesi-fen-bilimleri-enstitusu.csl (#5319) 87dc0eb Update and rename tijdschrift-voor-geneeskunde.csl to tijdschrift-voo… (#5325) 89e07b0 Create university-of-gothenburg-apa7-swedish-legislations (#5316) 4582cb6 Create chinese-law-journals.csl (#5314) 6412083 Create stellenbosch-law-review.csl (#5322) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: e1acabe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked by @tobiasdiez in the gitter-chat, a seperate PR to test if the font tweak can be safely removed, as probably the dependencies were removed in JavaFX anyways. See https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8187147